Changeset 13720 for sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-bad-request.php

Timestamp:

05/17/2024 02:09:30 AM (2 years ago)

Author:

dd32

Message:

Plugins: Add a hotfix for two semi-annoying PHP warnings that invalid requests trigger.

See ​https://github.com/GlotPress/GlotPress/pull/1835
See ​https://core.trac.wordpress.org/ticket/60261

File:

• sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-bad-request.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-bad-request.php

@@ -183 +183 @@
 
 /**
+ * Detect invalid charsets to trackbacks.
+ * Hotfix for https://core.trac.wordpress.org/ticket/60261
+ */
+add_action( 'template_redirect', function() {
+        if ( ! is_trackback() ) {
+                return;
+        }
+
+        $charset = str_replace( array( ',', ' ' ), '', strtoupper( trim( $_POST['charset'] ?? '' ) ) );
+
+        if ( function_exists( 'mb_list_encodings' ) && ! in_array( $charset, mb_list_encodings(), true ) ) {
+                die_bad_request( 'Invalid Charset' );
+        }
+} );
+
+/**
+ * Detect invalid requests to GlotPress
+ *
+ * Hotfix for https://github.com/GlotPress/GlotPress/pull/1835
+ */
+add_action( 'gp_init', function() {
+        $only_array_values = [ 'filter', 'sort' ];
+
+        foreach ( $only_array_values as $query_var ) {
+                if ( isset( $_GET[ $query_var ] ) && ! is_array( $_GET[ $query_var ] ) ) {
+                        if ( empty( $_GET[ $query_var ] ) ) {
+                                // If it's not set to anything, just silently discard the value.
+                                unset( $_GET[ $query_var ], $_REQUEST[ $query_var ] );
+                                continue;
+                        }
+
+                        die_bad_request( "non-array $query_var in GlotPress" );
+                }
+        }
+} );
+
+/**
  * Die with a 400 Bad Request.
  *