Changeset 13724

Timestamp:

05/17/2024 03:44:04 AM (10 months ago)

Author:

dd32

Message:

Plugin Directory: ZIP: Discard warnings from sort when piped into head.

Sort will throw STDERR data when head hangs up on it - which is intentional here, since we only want the first 10 characters of data.
The presence of error output in the log makes it appear like something may have gone wrong, when it's actually working as expected.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-builder.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-builder.php

@@ -406 +406 @@
      */
     protected function fix_directory_dates() {
-        // Find all files, output their modified dates, sort reverse numerically, grab the timestamp from the first entry
+        /*
+         * Find all files, output their modified dates, sort reverse numerically, grab the timestamp from the first entry
+         * Note: `sort | head` will generate STDERR output. This is expected and not a cause of concern. Silence it to remove red herrings.
+         */
         $latest_file_modified_timestamp = $this->exec( sprintf(
-            "find %s -type f -printf '%%T@\n' | sort -nr | head -c 10",
+            "find %s -type f -printf '%%T@\n' | sort -nr 2>/dev/null | head -c 10",
             escapeshellarg( $this->tmp_build_dir )
         ) );