Changeset 13784

Timestamp:

06/07/2024 04:40:29 AM (9 months ago)

Author:

coffee2code

Message:

Photo Directory, User: Exclude submission errors by default when calculating the count of a user's rejections.

Props nilovelez, coffee2code.
Fixes #7588.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/user.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/user.php

@@ -118 +118 @@
      * Returns a count of rejected photos for a user.
      *
-     * @param int $user_id Optional. The user ID. If not defined, assumes global
-     *                     author. Default false.
-     * @return int
-     */
-    public static function count_rejected_photos( $user_id = false ) {
+     * @param int $user_id                    Optional. The user ID. If not defined,
+     *                                        assumes global author. Default false.
+     * @param bool $exclude_submission_errors Optional. Should photos rejected due
+     *                                        to the 'submission-error' reason be
+     *                                        excluded from the count? Default true.
+     * @return int
+     */
+    public static function count_rejected_photos( $user_id = false, $exclude_submission_errors = true ) {
         global $wpdb;
 
-        if (  ! $user_id ) {
+        if ( ! $user_id ) {
             global $authordata;
 
@@ -135 +138 @@
         }
 
-        return (int) $wpdb->get_var( $wpdb->prepare(
-            "SELECT COUNT(*) FROM $wpdb->posts WHERE post_type = %s AND post_status = %s AND post_author = %d",
-            Registrations::get_post_type(),
-            Rejection::get_post_status(),
-            $user_id
-        ) );
+        $args = [
+            'post_type'      => Registrations::get_post_type(),
+            'post_status'    => Rejection::get_post_status(),
+            'author'         => $user_id,
+            'fields'         => 'ids',
+            'posts_per_page' => -1,
+        ];
+
+        if ( $exclude_submission_errors ) {
+            $args['meta_query'] = [
+                [
+                    'key'      => 'rejected_reason',
+                    'value'    => 'submission-error',
+                    'compare'  => '!=',
+                ],
+            ];
+        }
+
+        $query = new \WP_Query( $args );
+        return $query->found_posts;
     }