Changeset 1379

Timestamp:

03/05/2015 08:46:57 AM (10 years ago)

Author:

obenland

Message:

WP.org Themes: Pull hardcoded URLs out of translatable strings.

H/t tacoverdo.
See ​https://wordpress.slack.com/archives/meta-i18n/p1425539593000131

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

@@ -336 +336 @@
     if ( 'publish' == $post->post_status ) {
         $subject = sprintf( __( '[WordPress Themes] %1$s %2$s is now live', 'wporg-themes' ), $post->post_title, $version );
-        $content = sprintf( __( 'Version %1$s of %2$s is now live at https://wordpress.org/themes/%3$s.', 'wporg-themes' ), $version, $post->post_title, $post->post_name ) . "\n\n";
+        // Translators: 1: Theme version number; 2: Theme name; 3: Theme URL.
+        $content = sprintf( __( 'Version %1$s of %2$s is now live at %3$s.', 'wporg-themes' ), $version, $post->post_title, "https://wordpress.org/themes/{$post->post_name}" ) . "\n\n";
 
     } else {
         $subject = sprintf( __( '[WordPress Themes] %s has been approved!', 'wporg-themes' ), $post->post_title );
-        $content = sprintf( __( 'Congratulations, your new theme %1$s is now available to the public at https://wordpress.org/themes/%2$s.', 'wporg-themes' ), $post->post_title, $post->post_name ) . "\n\n";
+        // Translators: 1: Theme name; 2: Theme URL.
+        $content = sprintf( __( 'Congratulations, your new theme %1$s is now available to the public at %2$s.', 'wporg-themes' ), $post->post_title, "https://wordpress.org/themes/{$post->post_name}" ) . "\n\n";
 
         // First time approval: Publish the theme.
@@ -372 +374 @@
     // Notify theme author.
     $subject  = sprintf( __( '[WordPress Themes] %s - feedback', 'wporg-themes' ), $post->post_title );
-    $content  = sprintf( __( 'Feedback for the %1$s theme is at https://themes.trac.wordpress.org/ticket/%2$s', 'wporg' ) . "\n\n--\n", $post->post_title, $ticket_id );
+    // Translators: 1: Theme name; 2: Ticket URL.
+    $content  = sprintf( __( 'Feedback for the %1$s theme is at %2$s', 'wporg' ) . "\n\n--\n", $post->post_title, "https://themes.trac.wordpress.org/ticket/{$ticket_id}" );
     $content .= __( 'The WordPress.org Themes Team', 'wporg-themes' ) . "\n";
     $content .= 'https://make.wordpress.org/themes';