Changeset 1387 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

Timestamp:

03/09/2015 06:26:28 AM (10 years ago)

Author:

obenland

Message:

WP.org Themes: Avoid warnings when adding a new version on upload.

If it's a first-time theme upload, $meta will be false and checking a
previous status of that new version will trigger a warning.
On all other uploads the new version number will not be set, also triggering
a warning.

See ​https://wordpress.slack.com/archives/dotorg-warnings/p1425880912003372

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

@@ -276 +276 @@
  */
 function wporg_themes_update_version_status( $post_id, $current_version, $new_status ) {
-    $meta       = get_post_meta( $post_id, '_status', true );
-    $old_status = $meta[ $current_version ];
+    $meta       = (array) get_post_meta( $post_id, '_status', true );
+    $old_status = isset( $meta[ $current_version ] ) ? $meta[ $current_version ] : false;
 
     // Don't do anything when the status hasn't changed.