Changeset 1390 for sites/trunk/wordpress.tv/public_html/wp-content/themes/wptv2/functions.php

Timestamp:

03/10/2015 10:00:55 PM (11 years ago)

Author:

iandunn

Message:

WordPress.tv: Disable expensive search sort to avoid 504 errors.

File:

• sites/trunk/wordpress.tv/public_html/wp-content/themes/wptv2/functions.php (modified) (1 diff)

sites/trunk/wordpress.tv/public_html/wp-content/themes/wptv2/functions.php

@@ -214 +214 @@
 
         /**
+         * Sort the search results by the number of views each post has
+         *
          * @param WP_Query $query
          */
         function search_pre_get_posts( $query ) {
+                /*
+                 * @todo Optimize this before re-enabling
+                 *
+                 * This method was disabled because it caused 504 errors on large result sets
+                 * (e.g., http://wordpress.tv/?s=keynote). Sorting by a meta value is not performant.
+                 *
+                 * Maybe look at ways to do the sorting in PHP, or just use Elasticsearch instead.
+                 */
+                return;
+
                 if ( ! $query->is_main_query() || ! $query->is_search ) {
                         return;