Changeset 13930

Timestamp:

07/26/2024 04:42:27 AM (2 years ago)

Author:

dd32

Message:

Plugin Directory: Release Confirmation: Simplify the UI by moving the page-headers to the shortcode.

See ​https://github.com/WordPress/wordpress.org/pull/344.
See #7704.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/metabox/class-release-confirmation.php (modified) (1 diff)
• shortcodes/class-release-confirmation.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-release-confirmation.php

@@ -31 +31 @@
 
                 if ( $post->release_confirmation ) {
-                        Release_Confirmation_Shortcode::single_plugin( $post, $include_header = false );
+                        Release_Confirmation_Shortcode::single_plugin( $post );
                 }
         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-release-confirmation.php

@@ -91 +91 @@
                 $not_enabled = [];
                 foreach ( $plugins as $plugin ) {
+                        printf(
+                                '<h2><a href="%s">%s</a></h2>',
+                                get_permalink( $plugin ),
+                                get_the_title( $plugin )
+                        );
+
                         self::single_plugin( $plugin );
 
@@ -116 +122 @@
         }
 
-        static function single_plugin( $plugin, $include_header = true ) {
+        static function single_plugin( $plugin ) {
                 $releases = Plugin_Directory::get_releases( $plugin );
-
-                if ( $include_header ) {
-                        printf(
-                                '<h2><a href="%s">%s</a></h2>',
-                                get_permalink( $plugin ),
-                                get_the_title( $plugin )
-                        );
-                }
 
                 echo '<table class="widefat plugin-releases-listing">