Changeset 1397 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

Timestamp:

03/13/2015 12:04:27 PM (10 years ago)

Author:

obenland

Message:

WP.org Themes: Don't update theme post until new version was approved.

Theme description and tags might change in new versions, so the post can't be
updated with that new information until that version has been approved.

This also fixes a bug where the post date would be set to the upload date of
the new version, mixing new themes with updated themes in the Latest Themes
view in the Directory.

Fixes #943.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -525 +525 @@
     public function create_or_update_theme_post( $ticket_id ) {
         $upload_date = current_time( 'mysql' );
-        $post_args   = array(
-            'post_author'    => $this->author->ID,
-            'post_title'     => $this->theme->get( 'Name' ),
-            'post_name'      => $this->theme_slug,
-            'post_content'   => $this->theme->get( 'Description' ),
-            'post_parent'    => $this->theme->post_parent,
-            'post_date'      => $upload_date,
-            'comment_status' => 'closed',
-            'ping_status'    => 'closed',
-            'post_type'      => 'repopackage',
-            'tags_input'     => $this->theme->get( 'Tags' ),
-        );
-
-        // If we already have a post, update it.
+
+        // If we already have a post, get its ID.
         if ( ! empty( $this->theme_post ) ) {
-            $post_args['ID'] = $this->theme_post->ID;
-
-            $post_id = wp_update_post( $post_args );
-
-            // Otherwise create it for this new theme.
+            $post_id = $this->theme_post->ID;
+
+        // Otherwise create it for this new theme.
         } else {
-            $post_id = wp_insert_post( $post_args );
+            $post_id = wp_insert_post( array(
+                'post_author'    => $this->author->ID,
+                'post_title'     => $this->theme->get( 'Name' ),
+                'post_name'      => $this->theme_slug,
+                'post_content'   => $this->theme->get( 'Description' ),
+                'post_parent'    => $this->theme->post_parent,
+                'post_date'      => $upload_date,
+                'post_date_gmt'  => $upload_date,
+                'comment_status' => 'closed',
+                'ping_status'    => 'closed',
+                'post_type'      => 'repopackage',
+                'tags_input'     => $this->theme->get( 'Tags' ),
+            ) );
         }