Changeset 13996

Timestamp:

08/26/2024 11:10:57 PM (6 weeks ago)

Author:

coffee2code

Message:

Photo Directory, Rejection: Help prevent unintended rejection of published photo.

• Disable rejection reason dropdown for published photos by default.
• Add a checkbox above rejection dropdown to enable rejection reason dropdown and emphasize that photo is already published.
• Add a warning adjacent to 'Reject' button that appears if published photo is about to be rejected.

Fixes #7751.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/rejection.php (modified) (6 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/rejection.php

@@ -814 +814 @@
 
         $selected = self::get_rejection_reason( $post );
-        $is_disabled = in_array( get_post_status( $post ), [ 'trash', self::get_post_status() ] );
+        $is_disabled = in_array( get_post_status( $post ), [ 'publish', 'trash', self::get_post_status() ] );
 
         echo "<style>
@@ -826 +826 @@
             .reject-action.post-is-rejected input[type=submit] { background-color: #2271b1; border-color: #2271b1; }
             .reject-action input[type=submit]:hover { background-color: #8f2424; border-color: #8f2424; color: white; }
+
+            .reject-warn-if-published { border:1px solid #856404; background-color: #fff3cd; color: #856404; padding: 8px; margin-bottom: 0.5rem; }
+            .reject-warn-if-about-to-reject-published { border: 1px solid #721c24; background-color: #f8d7da; color: #721c24; padding: 8px 12px; margin-bottom: 0.5rem; }
         </style>\n";
 
@@ -838 +841 @@
                 // Bind changing of value of rejection reason dropdown to toggle whether reject or publish button is enabled.
                 const rejectSelect = document.querySelector('#rejected_reason');
-                rejectSelect.addEventListener('change', (event) => {
+                rejectSelect?.addEventListener('change', (event) => {
                     const hasRejectReason = Boolean(event.target.value);
                     // Publish button should be disabled if a rejection reason is selected.
@@ -844 +847 @@
                     // Reject button should be disabled if no rejection reason is selected.
                     document.querySelector('#reject-post').disabled = !hasRejectReason;
+                    // Notice of rejection of published post should be shown if post is published.
+                    const rejectPublishWarn = document.querySelector('.reject-warn-if-about-to-reject-published');
+                    if ( rejectPublishWarn ) {
+                        rejectPublishWarn.style.display = ( hasRejectReason ? 'block' : 'none' );
+                    }
+                });
+
+                // Bind checkbox for enabling rejection of published photo.
+                const cbRejectPublished = document.querySelector('#reject-warn-if-reject-published');
+                cbRejectPublished?.addEventListener('change', (event) => {
+                    if (rejectSelect) {
+                        rejectSelect.disabled = !event.target.checked;
+                    }
                 });
 
@@ -852 +868 @@
         </script>
 JS;
+
+        // Show a notice if the post is already published and a checkbox for enabling rejection field.
+        if ( 'publish' === get_post_status( $post ) ) {
+            echo '<div class="reject-warn-if-published">';
+            echo '<label class="warn-if-reject-published-container"><input id="reject-warn-if-reject-published" type="checkbox" name="reject_warn_if_reject_published" />';
+            esc_html_e( 'Allow rejection of published photo?', 'wporg-photos' );
+            echo "</label></div>\n";
+        }
 
         echo '<label for="rejected_reason">' . __( 'Reject due to:', 'wporg-photos' ) . '<br>';
@@ -886 +910 @@
 
         echo "</div></div>\n";
+
+        // Output a notice adjacent to reject button for use if about to reject a published post.
+        if ( 'publish' === get_post_status( $post ) ) {
+            echo '<div class="reject-warn-if-about-to-reject-published" style="display:none;" >';
+            esc_html_e( 'Warning: You are about to reject a published photo!', 'wporg-photos' );
+            echo "</div>\n";
+        }
 
         $is_rejected = self::is_post_rejected( $post );