Changeset 14078

Timestamp:

09/25/2024 04:48:38 AM (4 months ago)

Author:

dd32

Message:

Plugin Directory: Plugin check on upload: When running plugin check against an uploaded ZIP file, attempt to force the plugin to be installed into the expected folder path.

This resolves issues of plugin check suggesting that the textdomain should be 2024_09_25-uploaded-file-SLUG rather than SLUG.

This is intended on being temporary until the upstream issue is resolved.

See #7405.
See ​https://github.com/WordPress/wordpress-playground/issues/1802.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-blueprint.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-blueprint.php

@@ -195 +195 @@
         if ( $helper_zip && $install_prh ) {
             $steps[] = (object)[
-                    'step' => 'installPlugin',
-                    'pluginZipFile' => [
-                        'resource' => 'url',
-                        'url'      => $helper_zip,
-                    ],
-                    'options' => (object)[
-                        'activate' => (bool)$activate_plugin
-                    ]
-                ];
+                'step' => 'installPlugin',
+                'pluginZipFile' => [
+                    'resource' => 'url',
+                    'url'      => $helper_zip,
+                ],
+                'options' => (object)[
+                    'activate' => (bool)$activate_plugin
+                ]
+            ];
         }
 
@@ -224 +224 @@
         // Now the plugin itself
         $steps[] = (object)[
-                    'step' => 'installPlugin',
-                    'pluginZipFile' => (object)[
-                        'resource' => 'url',
-                        'url'      => $zip_url,
-                    ],
-                    'options' => (object)[
-                        'activate' => (bool)$activate_plugin
-                    ]
-                ];
+            'step' => 'installPlugin',
+            'pluginZipFile' => (object)[
+                'resource' => 'url',
+                'url'      => $zip_url,
+            ],
+            'options' => (object)[
+                'activate' => (bool)$activate_plugin
+            ]
+        ];
+
+        /*
+         * Maybe rename the plugin to exist in the expected folder.
+         *
+         * Temporary workaround for https://github.com/WordPress/wordpress-playground/issues/1802
+         */
+        if ( ! str_starts_with( 'https://downloads.wordpress.org/', $zip_url ) ) {
+            $steps[] = (object)[
+                'step' => 'runPHP',
+                'code' => '<?php
+                    include "/wordpress/wp-load.php";
+                    $expected_slug = ' . var_export( $plugin->post_name, true ) . ';
+                    $expected_plugins = ' . var_export( array_merge( [ 'plugin-check', 'playground-review-helper' ], $dependencies ), true ) . ';
+                    $installed_plugins = array_diff(
+                        array_map( "basename", glob( WP_PLUGIN_DIR . "/*", GLOB_ONLYDIR ) ),
+                        $expected_plugins
+                    );
+                    if ( 1 === count( $installed_plugins) ) {
+                        $plugin_dir = reset( $installed_plugins );
+                        if ( $plugin_dir !== $expected_slug ) {
+                            if ( rename( WP_PLUGIN_DIR . "/" . $plugin_dir, WP_PLUGIN_DIR . "/" . $expected_slug ) ) {
+                                $active_plugins = get_option( "active_plugins" );
+                                foreach ( $active_plugins as &$active_plugin ) {
+                                    if ( 0 === strpos( $active_plugin, $plugin_dir ) ) {
+                                        $active_plugin = $expected_slug . substr( $active_plugin, strlen( $plugin_dir ) );
+                                    }
+                                }
+                                update_option( "active_plugins", $active_plugins );
+                            }
+                        }
+                    }
+                '
+            ];
+        }
 
         // Finally log in
         $steps[] = (object)[
-                    'step' => 'login',
-                    'username' => 'admin',
-                    'password' => 'password',
-                ];
+            'step' => 'login',
+            'username' => 'admin',
+            'password' => 'password',
+        ];
 
         $zip_blueprint->steps = $steps;