Changeset 14185

Timestamp:

11/20/2024 09:52:33 PM (13 months ago)

Author:

adamwood

Message:

Breathe 2024: Hide welcome box on other pages

This change hides the welcome box by default on pages other than the home page.
The welcome box usually contains heading tags, and when displayed breaks the heading hierarchy on pages where there is no h1 in the local nav bar.
Visibility can still be toggled via the button.

Closes ​https://github.com/WordPress/wordpress.org/issues/382

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-breathe-2024/functions.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-breathe-2024/functions.php

@@ -344 +344 @@
     $welcome      = get_page_by_path( 'welcome' );
     $cookie       = 'welcome-' . get_current_blog_id();
+    $path         = get_blog_details()->path;
     $hash         = isset( $_COOKIE[ $cookie ] ) ? $_COOKIE[ $cookie ] : '';
     $content_hash = $welcome ? md5( $welcome->post_content ) : '';
@@ -377 +378 @@
         <div class="entry-content clear" id="make-welcome-content" data-cookie="<?php echo $cookie; ?>" data-hash="<?php echo $content_hash; ?>">
             <script type="text/javascript">
-                var elContent = document.getElementById( 'make-welcome-content' );
+                const elContent = document.getElementById( 'make-welcome-content' );
+
                 if ( elContent ) {
-                    if ( -1 !== document.cookie.indexOf( elContent.dataset.cookie + '=' + elContent.dataset.hash ) ) {
-                        var elToggle = document.getElementById( 'make-welcome-toggle' ),
-                            elEditLink = document.getElementsByClassName( 'make-welcome-edit-post-link' ),
-                            elContainer = document.querySelector( '.make-welcome' );
+                    const hasCookieSetToHidden = -1 !== document.cookie.indexOf( elContent.dataset.cookie + '=' + elContent.dataset.hash );
+                    const isHome = window.location.pathname === '<?php echo esc_js( $path ); ?>';
+
+                    if ( hasCookieSetToHidden || ! isHome ) {
+                        const elToggle = document.getElementById( 'make-welcome-toggle' );
+                        const elEditLink = document.getElementsByClassName( 'make-welcome-edit-post-link' );
+                        const elContainer = document.querySelector( '.make-welcome' );
 
                         // It's hidden, hide it ASAP.