Changeset 14246

Timestamp:

12/06/2024 04:45:07 AM (5 months ago)

Author:

dd32

Message:

Pugin Directory: Guess the submission date for pre-2017-April plugins, avoids showing it as '55 years ago'.

Followup to [14244].
See #7761.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-controls.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-controls.php

@@ -190 +190 @@
             <tr>
                 <td><?php _e( 'Updated:', 'wporg-plugins' ); ?></td>
-                <td><strong><?php printf( '<span title="%s">%s ago</span>', esc_attr( $post->last_updated ), human_time_diff( strtotime( $post->last_updated ) ) ); ?></strong></td>
+                <td><strong><?php
+                    printf(
+                        '<span title="%s">%s ago</span>',
+                        esc_attr( $post->last_updated ),
+                        human_time_diff( strtotime( $post->last_updated ) )
+                    );
+                ?></strong></td>
             </tr>
 
             <tr>
                 <td><?php _e( 'Submitted:', 'wporg-plugins' ); ?></td>
-                <td><strong><?php printf( '<span title="%s">%s ago</span>', esc_attr( gmdate( 'Y-m-d H:i:s', $post->_submitted_date ?? 0 ) ), human_time_diff( $post->_submitted_date ) ); ?></strong></td>
+                <td><strong><?php
+                    $submitted_date = min( array_filter( [
+                        $post->_submitted_date,           // Submitted date stored since 2017-04-11
+                        $post->_approved,                 // The approval date is the next best thing.
+                        strtotime( $post->post_date_gmt ) // Fallback to the post_date, which should be similar to approval date.
+                    ] ) );
+
+                    printf(
+                        '<span title="%s">%s ago</span>',
+                        esc_attr( gmdate( 'Y-m-d H:i:s', $submitted_date ) ),
+                        human_time_diff( $submitted_date )
+                    );
+                ?></strong></td>
             </tr>