Changeset 14375

Timestamp:

02/05/2025 03:20:13 AM (12 months ago)

Author:

dd32

Message:

Plugin Directory: Resolve PHP fatal ultimately caused by [14373] that serialised the steps array to an object.

This occured as json_encode( [ 2 => 'two' ] ) is an object, where as json_encode( [ 'one' ] ) is an array.

Follow up to [14373].

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -1305 +1305 @@
             $has_self_install_step = false;
             if ( isset( $decoded_file[ 'steps' ] ) ) {
-                $decoded_file[ 'steps' ] = array_filter( $decoded_file[ 'steps' ] ); // Null items are often present in auto-generated blueprints.
+                // Null & falsey items are often present in auto-generated blueprints, reindex to avoid serialising to an object.
+                $decoded_file[ 'steps' ] = array_values( array_filter( $decoded_file[ 'steps' ] ) );
 
                 foreach ( $decoded_file[ 'steps' ] as &$step ) {