Changeset 14439 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/lib/class-trac.php

Timestamp:

04/29/2025 01:06:56 AM (9 months ago)

Author:

dd32

Message:

Theme Directory: Trac: Remove the retry logic for create/update tasks.

Reverts [14435].
Partially Reverts [14431].

See ​https://wordpress.slack.com/archives/C02QB8GMM/p1745814509983439

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/lib/class-trac.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/lib/class-trac.php

@@ -63 +63 @@
         }
 
-        $ok = $this->rpc_query_retry( 5, 'ticket.create', $subj, $desc, $attr );
+        $ok = $this->rpc->query( 'ticket.create', $subj, $desc, $attr );
         if ( ! $ok ) {
             trigger_error( 'Trac: ticket.create: ' . $this->rpc->error->message, E_USER_WARNING );
@@ -98 +98 @@
         }
 
-        $ok = $this->rpc_query_retry( 5, 'ticket.update', $id, $comment, $attr, $notify );
+        $ok = $this->rpc->query( 'ticket.update', $id, $comment, $attr, $notify );
         if ( ! $ok ) {
             trigger_error( 'Trac: ticket.update: ' . $this->rpc->error->message, E_USER_WARNING );
@@ -115 +115 @@
      */
     public function ticket_query( $search ) {
-        $ok = $this->rpc->query( 'ticket.query', $search );
+        $ok = $this->rpc_query_retry( 3, 'ticket.query', $search );
         if ( ! $ok ) {
             return false;
@@ -163 +163 @@
 
             $ok = call_user_func_array( [ $this->rpc, 'query' ], $args );
-
-            // Don't retry on creation tasks, if it's a HTTP timeout. Retry on other errors.
-            if (
-                ! $ok &&
-                str_contains( $this->rpc->error->message, 'Operation timed out' ) &&
-                (
-                    str_contains( $args[0], 'create' ) ||
-                    str_contains( $args[0], 'update' )
-                )
-            ) {
-                break;
-            }
         }