Changeset 14441

Timestamp:

04/29/2025 04:23:40 PM (7 months ago)

Author:

coffee2code

Message:

Photo Directory, Admin: Don't calculate a rejection rate when contributor only has submission errors as rejections.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/admin.php

@@ -1175 +1175 @@
 
         $author = get_user_by( 'id', $post->post_author );
-        $photos_count = User::count_published_photos( $author->ID );
+        $published_count = User::count_published_photos( $author->ID );
         $account_created = explode( ' ', $author->user_registered )[0];
         ?>
@@ -1207 +1207 @@
                         printf(
                             __( 'Published photos: <strong>%s</strong>', 'wporg-photos' ),
-                            ( 0 === $photos_count )
-                                ? $photos_count
-                                : sprintf( '<a href="%s">%s</a>', get_author_posts_url( $author->ID ), $photos_count )
+                            ( 0 === $published_count )
+                                ? $published_count
+                                : sprintf( '<a href="%s">%s</a>', esc_url( get_author_posts_url( $author->ID ) ), $published_count )
                         );
                     ?></li>
@@ -1307 +1307 @@
 
                     echo '<p>';
-                    /* translators: %s: Rejection rate as a percentage. */
-                    printf( __( 'Total rejection rate: %s', 'wporg-photos'), '<strong>' . round( ( $total_rejections / ( $photos_count + $total_rejections ) ) * 100, 2 ) .'%</strong>' );
+                    $total_count = $published_count + $total_rejections;
+                    $rejection_rate = $total_count
+                        ? round( ( $total_rejections / $total_count ) * 100, 2 )
+                        : 0;
+
+                    printf(
+                        /* translators: %s: Rejection rate as a percentage. */
+                        __( 'Total rejection rate: %s', 'wporg-photos'),
+                        '<strong>' . $rejection_rate .'%</strong>'
+                    );
                     echo "</p>\n";