Changeset 14512

Timestamp:

08/12/2025 07:18:03 AM (6 weeks ago)

Author:

dd32

Message:

Theme Directory: Include the Theme Check output in the failure email when a theme author commits directly to SVN with an invalid theme.

BCC that email to the Themes Team helpscout instance for easier management of this case.

See ​https://core.trac.wordpress.org/ticket/63792

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory

Files:

• class-wporg-themes-upload.php (modified) (2 diffs)
• jobs/class-svn-import.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -703 +703 @@
         // Pass it through Theme Check and see how great this theme really is.
         if ( $args['run_themecheck'] ) {
+            ob_start();
             $result = $this->check_theme();
+            $theme_check_output = ob_get_clean();
+
+            // Output the Theme Check results. This is the only HTML that this function outputs.
+            echo $theme_check_output;
 
             if ( ! $result && $args['block_on_themecheck'] ) {
@@ -716 +721 @@
                         '//wordpress.org/plugins/theme-check/',
                         '<a href="https://make.wordpress.org/themes">https://make.wordpress.org/themes</a>'
-                    )
+                    ),
+                    $theme_check_output
                 );
             }

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/jobs/class-svn-import.php

@@ -133 +133 @@
             }
 
+            $error_message = $return->get_error_message();
+
+            // For theme check failures, include the HTML output by the TC functions.
+            if ( 'failed_theme_check' === $return->get_error_code() ) {
+                $error_message .= '<br><br>' . $return->get_error_data( 'failed_theme_check' );
+            }
+
             /*
              * Otherwise email the author about this problem.
@@ -157 +164 @@
                     esc_html( $uploader->author->display_name ?: $uploader->author->user_login ),
                     $uploader->theme->display('Name') . ' ' . $uploader->theme->display('Version'),
-                    '<div style="margin-left: 30px">' . $return->get_error_message() . '</div>',
+                    '<div style="margin-left: 30px">' . $error_message . '</div>',
                     'https://make.wordpress.org/themes/handbook/review/required/'
                 ),
                 [
                     'From: "WordPress Theme Directory" <themes@wordpress.org>',
-                    'Content-Type: text/html; charset=UTF-8'
+                    'Content-Type: text/html; charset=UTF-8',
+                    'BCC: themes@wordpress.org'
                 ]
             );