Changeset 14623 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-zip-cleanup.php

Timestamp:

01/06/2026 01:01:00 AM (4 months ago)

Author:

dd32

Message:

Plugin Directory: Jobs: Zip Cleanup: Avoid OOM errors by being more specific in what we're querying here.

See #5636.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-zip-cleanup.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-zip-cleanup.php

@@ -29 +29 @@
 
         $attachments = get_posts( [
+            'fields'         => 'id=>parent',
             'post_type'      => 'attachment',
             'post_mime_type' => 'application/zip',
@@ -38 +39 @@
                     'before' => self::KEEP_DAYS . ' days ago',
                 ]
-            ]
+            ],
+
+            // Don't prime caches, helps with some memory when we're not really using any of it.
+            'update_post_meta_cache' => false,
+            'update_post_term_cache' => false,
         ] );
 
-        foreach ( $attachments as $attachment ) {
-            $plugin = get_post( $attachment->post_parent );
+        foreach ( $attachments as $attachment_id => $plugin_id ) {
+            $plugin = get_post( $plugin_id );
 
             // If not a plugin upload, or something drastically is wrong..
-            if ( ! $attachment->post_parent || ! $plugin || 'plugin' !== $plugin->post_type ) {
+            if ( ! $plugin_id || ! $plugin || 'plugin' !== $plugin->post_type ) {
                 continue;
             }
@@ -63 +68 @@
             $plugin_last_touched_date = 0;
             foreach ( [ 'plugin_closed_date', '_approved', '_publish', '_rejected' ] as $meta_field ) {
-                $meta_value = get_post_meta( $plugin->ID, $meta_field, true );
+                $meta_value = get_post_meta( $plugin_id, $meta_field, true );
                 if ( ! $meta_value ) {
                     continue;
@@ -85 +90 @@
 
             // Cleanup ZIP-related metadata.
-            delete_post_meta( $plugin->ID, '_submitted_zip_size' );
-            delete_post_meta( $plugin->ID, '_submitted_zip_loc' );
+            delete_post_meta( $plugin_id, '_submitted_zip_size' );
+            delete_post_meta( $plugin_id, '_submitted_zip_loc' );
 
             // Delete the file hash from the post.
-            $file_on_disk = get_attached_file( $attachment );
+            $file_on_disk = get_attached_file( $attachment_id );
             if ( $file_on_disk && file_exists( $file_on_disk ) ) {
                 $file_hash = sha1_file( $file_on_disk );
@@ -97 +102 @@
             }
 
-            wp_delete_attachment( $attachment->ID, true );
+            wp_delete_attachment( $attachment_id, true );
         }
     }