Changeset 14653

Timestamp:

02/04/2026 07:07:00 AM (2 months ago)

Author:

dd32

Message:

Oficial WordPress Events: Use INSERT ON DUPLICATE KEY UPDATE rather than REPLACE to allow for other table columns to be set as needed from elsewhere. This also adds a first-seen 'created_at' column.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php

@@ -102 +102 @@
      */
     public function prime_events_cache() {
-        global $wpdb;
-
         $this->log( 'started call #' . did_action( 'owpe_prime_events_cache' ) );
 
@@ -117 +115 @@
         foreach ( $events as $event ) {
             $row_values = array(
-                'id'              => null,
                 'type'            => $event->type,
                 'source_id'       => $event->source_id,
@@ -134 +131 @@
                 'latitude'        => $event->latitude,
                 'longitude'       => $event->longitude,
+                'created_at'      => gmdate( 'Y-m-d H:i:s' ),
             );
 
@@ -141 +139 @@
             }
 
-            /*
-             * Insert the events into the table, without creating duplicates
-             *
-             * Note: Since replace() is matching against a unique key rather than the primary `id` key, it's
-             * expected for each row to be deleted and re-inserted, making the IDs increment each time.
-             *
-             * See http://stackoverflow.com/a/12205366/450127
-             */
-            $wpdb->replace( self::EVENTS_TABLE, $row_values );
+            $keys_not_to_update = array(
+                'created_at',
+            );
+
+            $this->insert_on_duplicate_key_update(
+                $wpdb->prefix . self::EVENTS_TABLE,
+                $row_values,
+                array_diff( array_keys( $row_values ), $keys_not_to_update )
+            );
         }
 
         $this->log( "finished job\n\n" );
+    }
+
+    /**
+     * INSERT INTO ... ON DUPLICATE KEY UPDATE ... helper
+     *
+     * @param string $table       The table to insert into.
+     * @param array  $data        Associative array of field => value pairs to insert.
+     * @param array  $update_keys Array of field names to update on duplicate key.
+     */
+    protected function insert_on_duplicate_key_update( string $table, array $data, array $update_keys ) {
+        global $wpdb;
+
+        $field_placeholders = [];
+        $value_placeholders = [];
+        $duplicate_sets     = [];
+        $field_args         = [];
+        $values_args        = [];
+        $duplicate_args     = [];
+        foreach ( $data as $field => $value ) {
+            $field_placeholders[] = '%i';
+            $value_placeholders[] = '%s';
+
+            $field_args[]  = $field;
+            $values_args[] = $value;
+
+            if ( $update_keys && in_array( $field, $update_keys, true ) ) {
+                $duplicate_sets[] = '%i = VALUES(%i)';
+                $duplicate_args[] = $field;
+                $duplicate_args[] = $field;
+            }
+        }
+
+        $field_placeholders = implode( ', ', $field_placeholders );
+        $value_placeholders = implode( ', ', $value_placeholders );
+        $duplicate_sets     = implode( ', ', $duplicate_placehodlers );
+
+        return $wpdb->query( $wpdb->prepare(
+            "INSERT INTO %i ( {$field_placeholders} ) VALUES ( {$value_placeholders} ) ON DUPLICATE KEY UPDATE {$duplicate_sets}",
+            $table,
+            ...$field_args,
+            ...$values_args,
+            ...$duplicate_args
+        ) );
     }