Changeset 1468

Timestamp:

04/03/2015 01:01:47 PM (9 years ago)

Author:

djpaul

Message:

BuddyPress.org/bbPress.org: replace hardcoded URLs with convenience functions for redirects and CSS loading.

These themes can now easily be run on a local dev environment. Until this change, you’ve had to use buddypress.org or bbpress.org (etc) as the domain name for your dev site. This is because the themes had a number of hardcoded redirects and URL detection which assumed the production URLs would always be used.

The change updates the redirects to use home_url, and creates new (filtered) wrapper functions used to determine if the theme is running on buddypress.org or bbpress.org.
This will help integrate the “bb” sites into ​https://github.com/iandunn/wordpress-meta-environment/.

Location:

sites/trunk/buddypress.org/public_html/wp-content

Files:

• plugins/bbpress-org/bbpress-dot-org.php (modified) (1 diff)
• plugins/buddypress-org/extensions.php (modified) (6 diffs)
• plugins/buddypress-org/toolbar.php (modified) (1 diff)
• themes/bb-base/functions.php (modified) (2 diffs)
• themes/buddypress-org/header-front.php (modified) (1 diff)

sites/trunk/buddypress.org/public_html/wp-content/plugins/bbpress-org/bbpress-dot-org.php

@@ -29 +29 @@
         return;
 
-    wp_safe_redirect( 'http://bbpress.org' );
+    wp_safe_redirect( home_url( '/' ) );
     die;
 }

sites/trunk/buddypress.org/public_html/wp-content/plugins/buddypress-org/extensions.php

@@ -91 +91 @@
     // Redirect /forums/ to /support/
     if ( $uri_chunks[1] === 'forums' && empty( $uri_chunks[2] ) ) {
-        bp_core_redirect( 'http://buddypress.org/support/' );
+        bp_core_redirect( home_url( '/support/' ) );
     }
 
     // Redirect members directory to root to block heavy paginated user queries
     if ( ( $uri_chunks[1] === 'members' ) && empty( $uri_chunks[2] ) ) {
-        bp_core_redirect( 'http://buddypress.org' );
+        bp_core_redirect( home_url( '/' ) );
     }
 
     // Redirect old members profile pages to
     if ( ( $uri_chunks[1] === 'community' ) && ( $uri_chunks[2] === 'members' ) && ! empty( $uri_chunks[3] ) ) {
-        bp_core_redirect( 'http://buddypress.org/members/' . $uri_chunks[3] . '/' );
+        bp_core_redirect( home_url( '/members/' . $uri_chunks[3] . '/' ) );
     }
 
@@ -109 +109 @@
         // Single group topic redirect
         if ( !empty( $uri_chunks[5] ) && ( $uri_chunks[5] === 'topic' ) ) {
-            bp_core_redirect( 'http://buddypress.org/support/topic/' . $uri_chunks[6] . '/' );
+            bp_core_redirect( home_url( '/support/topic/' . $uri_chunks[6] . '/' ) );
 
         // Single group forum redirect
@@ -116 +116 @@
             // Use legacy group slug
             if ( ! in_array( $uri_chunks[3], array( 'gallery', 'how-to-and-troubleshooting' ) ) ) {
-                bp_core_redirect( 'http://buddypress.org/support/forum/plugin-forums/' . $uri_chunks[3] . '/' );
+                bp_core_redirect( home_url( '/support/forum/plugin-forums/' . $uri_chunks[3] . '/' ) );
 
             // Root forums, maybe with new slug
@@ -124 +124 @@
                 switch ( $uri_chunks[3] ) {
                     case 'gallery' :
-                        $url = 'http://buddypress.org/support/forum/your-buddypress/';
+                        $url = '/support/forum/your-buddypress/';
                         break;
                     case 'how-to-and-troubleshooting' :
-                        $url = 'http://buddypress.org/support/forum/how-to/';
+                        $url = '/support/forum/how-to/';
                         break;
                     case 'creating-and-extending' :
-                        $url = 'http://buddypress.org/support/forum/extending/';
+                        $url = '/support/forum/extending/';
                         break;
                     case 'requests-and-feedback' :
-                        $url = 'http://buddypress.org/support/forum/feedback/';
+                        $url = '/support/forum/feedback/';
                         break;
                     case 'buddypress' :
-                        $url = 'http://buddypress.org/support/forum/installing/';
+                        $url = '/support/forum/installing/';
                         break;
                     case 'third-party-plugins' :
-                        $url = 'http://buddypress.org/support/forum/plugins/';
+                        $url = '/support/forum/plugins/';
                         break;
                     default:
@@ -145 +145 @@
                         break;
                 }
-                bp_core_redirect( $url );
+                bp_core_redirect( home_url( $url ) );
             }
         }
@@ -152 +152 @@
     // Redirect /support/topics/ to /support/
     if ( $uri_chunks[1] === 'support' && ( !empty( $uri_chunks[2] ) && ( 'topics' === $uri_chunks[2] ) ) ) {
-        bp_core_redirect( 'http://buddypress.org/support/' );
-    }
-}
-if ( 'buddypress.org' === $_SERVER['HTTP_HOST'] && ! is_admin() && defined( 'WP_USE_THEMES' ) && WP_USE_THEMES ) {
+        bp_core_redirect( home_url( '/support/' ) );
+    }
+}
+if ( (bool) strstr( $_SERVER['HTTP_HOST'], 'buddypress' ) && ! is_admin() && defined( 'WP_USE_THEMES' ) && WP_USE_THEMES ) {
     add_action( 'init', 'bporg_redirect', 1 ); // before bp_init
 }

sites/trunk/buddypress.org/public_html/wp-content/plugins/buddypress-org/toolbar.php

@@ -269 +269 @@
 
     // bbPress Codex
-    } elseif ( 'codex.bbpress.org' == $_SERVER['HTTP_HOST'] ) {
+    } elseif ( bb_base_is_bbpress() ) {
         $wp_admin_bar->add_menu( array(
             'id'    => 'bp-site-name',

sites/trunk/buddypress.org/public_html/wp-content/themes/bb-base/functions.php

@@ -23 +23 @@
 }
 
+/**
+ * Are we looking at a buddypress.org site?
+ *
+ * @return bool
+ */
+function bb_base_is_buddypress() {
+    $retval = (bool) strstr( $_SERVER['HTTP_HOST'], 'buddypress' );
+    return (bool) apply_filters( 'bb_base_is_buddypress', $retval );
+}
+
+/**
+ * Are we looking at a bbpress.org site?
+ *
+ * @return bool
+ */
+function bb_base_is_bbpress() {
+    $retval = (bool) strstr( $_SERVER['HTTP_HOST'], 'bbpress' );
+    return (bool) apply_filters( 'bb_base_is_bbpress', $retval );
+}
+
+
 // Include in Codex code on codex sites
 if ( bb_base_is_codex() ) {
@@ -40 +61 @@
 
     // Handle root styling for buddypress/bbpress
-    if ( strstr( $_SERVER['HTTP_HOST'], 'bbpress.org' ) ) {
+    if ( bb_base_is_bbpress() ) {
         $root = 'style-bbpress.css';
-    } elseif ( strstr( $_SERVER['HTTP_HOST'], 'buddypress.org' ) ) {
+    } elseif ( bb_base_is_buddypress() ) {
         $root = 'style-buddypress.css';
     }

sites/trunk/buddypress.org/public_html/wp-content/themes/buddypress-org/header-front.php

@@ -1 @@
-<?php if ( 'buddypress.org' === parse_url( get_home_url(), PHP_URL_HOST ) && is_front_page() ) : ?>
+<?php if ( bb_base_is_buddypress() && is_front_page() ) : ?>
 
     <div id="headline"><div id="headline-inner">