Changeset 14714

Timestamp:

03/13/2026 08:03:05 PM (4 weeks ago)

Author:

obenland

Message:

WP.org Abilities: Optimize get_feedback() to short-circuit on latest reviewer message.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/tools/class-get-plugin-status.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/tools/class-get-plugin-status.php

@@ -280 +280 @@
             }
 
+            // When only the latest reviewer message is needed, find it directly.
+            if ( ! $full_history ) {
+                foreach ( $threads as $thread ) {
+                    if ( in_array( $thread->type ?? '', array( 'reply', 'message' ), true ) ) {
+                        $body = $thread->body ?? '';
+                        if ( $body ) {
+                            $body = self::html_to_text( $body );
+                            $body = self::strip_boilerplate( $body );
+                        }
+
+                        return array(
+                            array(
+                                'from' => 'reviewer',
+                                // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- HelpScout API property.
+                                'date' => $thread->createdAt ?? '',
+                                'body' => $body,
+                            ),
+                        );
+                    }
+                }
+
+                // No reviewer message found in this email, try next.
+                continue;
+            }
+
+            // Full history: process all threads.
             foreach ( $threads as $thread ) {
                 // Skip internal notes and system events — only include customer and agent messages.
@@ -302 +328 @@
 
         // Return in chronological order (oldest first) so it reads as a conversation.
-        $feedback = array_reverse( $feedback );
-
-        // By default, return only the most recent reviewer message.
-        if ( ! $full_history ) {
-            for ( $i = count( $feedback ) - 1; $i >= 0; $i-- ) {
-                if ( 'reviewer' === $feedback[ $i ]['from'] ) {
-                    return array( $feedback[ $i ] );
-                }
-            }
-        }
-
-        return $feedback;
+        return array_reverse( $feedback );
     }