Changeset 14725

Timestamp:

03/17/2026 03:06:51 PM (4 weeks ago)

Author:

obenland

Message:

WP.org Abilities: Improve tool schemas and reduce duplication in prompts

Add URI format hints to URL inputs, clarify mutually exclusive options in descriptions, and use a consistent base class across all abilities.
Prompts now reference workflows instead of duplicating instructions.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory

Files:

• class-ability-base.php (modified) (1 diff)
• prompts/class-address-review-feedback.php (modified) (1 diff)
• prompts/class-prepare-plugin.php (modified) (1 diff)
• resources/class-plugin-check-guide.php (modified) (2 diffs)
• tools/class-submit-plugin.php (modified) (1 diff)
• tools/class-validate-readme.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/class-ability-base.php

@@ -37 +37 @@
      * Load the plugin-directory autoloader and switch to the plugins blog.
      *
-     * Registers the plugin-directory autoloader so abilities can reference classes
-     * like Readme\Validator and Trademarks, and switches to the plugins blog so
-     * queries run against the correct posts table.
+     * Permanently switches to the plugins blog for the remainder of the request.
+     * All plugin-directory abilities expect to run in this context.
      */
     protected static function maybe_load_plugin_directory(): void {

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/prompts/class-address-review-feedback.php

@@ -80 +80 @@
 ## Step 4: Re-validate
 
-After all fixes:
-1. Re-run Plugin Check locally to ensure no new issues were introduced:
-```bash
-wp plugin check {$plugin_slug} --categories=plugin_repo --format=json --error-severity=7 --warning-severity=6 --include-low-severity-errors --exclude-checks=prefixing
-```
-2. Review the fixes against `wporg://plugins/plugin-directory/plugin-guidelines`
+After all fixes, use the `wporg/plugins/plugin-directory/run-plugin-check` prompt with the plugin path to re-run Plugin Check and ensure no new issues were introduced.
+
+Review the fixes against `wporg://plugins/plugin-directory/plugin-guidelines`.
 
 ## Step 5: Resubmit

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/prompts/class-prepare-plugin.php

@@ -93 +93 @@
 ## Step 4: Run Plugin Check Locally
 
-Run the Plugin Check (PCP) plugin locally using WP-CLI:
+Use the `wporg/plugins/plugin-directory/run-plugin-check` prompt with plugin_path `{$plugin_path}` to run and resolve all Plugin Check issues.
 
-```bash
-wp plugin check {$plugin_path} --categories=plugin_repo --format=json --error-severity=7 --warning-severity=6 --include-low-severity-errors --exclude-checks=prefixing
-```
-
-If PCP is not installed, install it first: `wp plugin install plugin-check --activate`
-
-Fix all ERRORs before proceeding. See `wporg://plugins/plugin-directory/plugin-check-guide` for details.
+Fix all ERRORs before proceeding.
 
 ## Step 5: Check Slug Availability

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/resources/class-plugin-check-guide.php

@@ -10 +10 @@
 namespace WordPressdotorg\Abilities\Plugins\Plugin_Directory\Resources;
 
+use WordPressdotorg\Abilities\Plugins\Plugin_Directory\Ability_Base;
+
 defined( 'ABSPATH' ) || exit;
 
@@ -15 +17 @@
  * Plugin_Check_Guide class.
  */
-class Plugin_Check_Guide {
+class Plugin_Check_Guide extends Ability_Base {
 
     /**

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/tools/class-submit-plugin.php

@@ -52 +52 @@
                         'zip_url'       => array(
                             'type'        => 'string',
+                            'format'      => 'uri',
                             'description' => 'URL to download the plugin ZIP from. Must be a publicly accessible HTTPS URL ending in .zip. Preferred for larger plugins. Provide exactly one of zip_url or zip_base64.',
                         ),

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-abilities/plugins/plugin-directory/tools/class-validate-readme.php

@@ -35 +35 @@
                         'content' => array(
                             'type'        => 'string',
-                            'description' => 'The full text content of the readme.txt or readme.md file to validate.',
+                            'description' => 'The full text content of the readme.txt or readme.md file to validate. Provide either content or url, not both.',
                         ),
                         'url'     => array(
                             'type'        => 'string',
-                            'description' => 'URL to a readme.txt or readme.md file to fetch and validate. Must end in readme.txt or readme.md.',
+                            'format'      => 'uri',
+                            'description' => 'URL to a readme.txt or readme.md file to fetch and validate. Must end in readme.txt or readme.md. Provide either url or content, not both.',
                         ),
                     ),