Changeset 1473

Timestamp:

04/08/2015 07:13:30 PM (10 years ago)

Author:

obenland

Message:

WP.org Themes: Avoid updating the post date when a theme gets published after having been reinstated.

See ​https://wordpress.slack.com/archives/meta/p1428484661000249

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory

Files:

• admin-edit.php (modified) (1 diff)
• theme-directory.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/admin-edit.php

@@ -223 +223 @@
         'post_status' => 'draft',
     ) );
+
+    /*
+     * Mark it as reinstated, so the post date doesn't get overwritten when it's
+     * published again.
+     */
+    add_post_meta( $post_id, '_wporg_themes_reinstated', true );
 
     wp_redirect( add_query_arg( 'reinstated', 1, remove_query_arg( array( 'trashed', 'untrashed', 'deleted', 'ids', 'suspended' ), wp_get_referer() ) ) );

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

@@ -373 +373 @@
         $content = sprintf( __( 'Congratulations, your new theme %1$s is now available to the public at %2$s.', 'wporg-themes' ), $post->post_title, "https://wordpress.org/themes/{$post->post_name}" ) . "\n\n";
 
-        /*
-         * First time approval: Publish the theme.
-         *
-         * Uses `wp_update_post()` to also update post_time.
-         */
-        $post_date = current_time( 'mysql' );
-        wp_update_post( array(
-            'ID'            => $post_id,
-            'post_status'   => 'publish',
-            'post_date'     => $post_date,
-            'post_date_gmt' => $post_date,
-        ) );
+        // First time approval: Publish the theme.
+        $post_args = array(
+            'ID'          => $post_id,
+            'post_status' => 'publish',
+        );
+
+        // Update post_time if it wasn't suspended before.
+        if ( get_post_meta( $post_id, '_wporg_themes_reinstated', true ) ) {
+            delete_post_meta( $post_id, '_wporg_themes_reinstated' );
+        } else {
+            $post_date = current_time( 'mysql' );
+
+            $post_args['post_date']     = $post_date;
+            $post_args['post_date_gmt'] = $post_date;
+        }
+
+        wp_update_post( $post_args );
     }