Changeset 1475 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/extras.php

Timestamp:

04/14/2015 05:00:22 AM (10 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Improve page title generation.

• Discontinue inclusion of blog_description in homepage title (mostly duplicates site name).
• Append instead of prepend the separator when including page number.
• Use is_parsed_post_type() rather than a direct, vague check.

Fixes #991.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/extras.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/extras.php

@@ -53 +53 @@
 
     // Add post type to title if it's a parsed item.
-    if ( is_singular() && 0 === strpos( $post_type, 'wp-parser-' ) ) {
+    if ( is_singular() && \DevHub\is_parsed_post_type( $post_type ) ) {
         if ( $post_type_object = get_post_type_object( $post_type ) ) {
             $title .= get_post_type_object( $post_type )->labels->singular_name . " $sep ";
@@ -74 +74 @@
     }
 
-    // Add the blog description for the home/front page.
-    $site_description = get_bloginfo( 'description', 'display' );
-    if ( $site_description && ( is_home() || is_front_page() ) ) {
-        $title .= " $sep $site_description";
-    }
-
     // Add a page number if necessary:
     if ( $paged >= 2 || $page >= 2 ) {
-        $title .= " $sep " . sprintf( __( 'Page %s', 'wporg' ), max( $paged, $page ) );
+        $title .= sprintf( __( 'Page %s', 'wporg' ), max( $paged, $page ) ) . " $sep ";
     }