Changeset 14885

Timestamp:

05/14/2026 02:57:35 PM (10 days ago)

Author:

amieiro

Message:

Translate: add validator opt-out for the translation editor top bar

• new "Hide the validation top bar in the translation editor" checkbox at /settings/
• visible only to validators (global admin, GTE, Locale Manager, PTE)
• when checked, the top bar template and assets are not loaded on translation pages

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates

Files:

• helper-functions.php (modified) (2 diffs)
• settings-edit.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/helper-functions.php

@@ -188 +188 @@
         return false;
     }
+
+    // Per-user opt-out: validators can hide the top bar persistently from /settings/.
+    // Stored as `hide_validator_topbar => 'on'` inside the user's `gp_default_sort`
+    // option (piggybacks on the existing settings form — see settings-edit.php).
+    $default_sort = get_user_option( 'gp_default_sort' );
+    if ( 'on' === gp_array_get( $default_sort, 'hide_validator_topbar', 'off' ) ) {
+        return false;
+    }
+
     return GP::$permission->current_user_can(
         'approve',
@@ -194 +203 @@
     );
 }
+
+/**
+ * Returns true if the given user has the ability to approve translations on
+ * at least one translation set — i.e., is a global GlotPress admin, a GTE,
+ * a Locale Manager, or a PTE somewhere. 
+ *
+ * @param int $user_id The user ID to check. 0 or missing returns false.
+ * @return bool
+ */
+function wporg_translate_user_is_validator_anywhere( $user_id ) {
+    static $cache = array();
+
+    $user_id = (int) $user_id;
+    if ( $user_id <= 0 ) {
+        return false;
+    }
+
+    if ( array_key_exists( $user_id, $cache ) ) {
+        return $cache[ $user_id ];
+    }
+
+    $rosetta = \WordPressdotorg\GlotPress\Rosetta_Roles\Plugin::get_instance();
+    if ( $rosetta->is_global_administrator( $user_id ) ) {
+        $cache[ $user_id ] = true;
+        return true;
+    }
+
+    global $wpdb;
+
+    // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching -- static-map cache is sufficient for this single-row existence check.
+    $has_editor_row = $wpdb->get_var(
+        $wpdb->prepare(
+            "SELECT 1 FROM {$wpdb->wporg_translation_editors}
+             WHERE user_id = %d LIMIT 1",
+            $user_id
+        )
+    );
+    // phpcs:enable WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
+    if ( $has_editor_row ) {
+        $cache[ $user_id ] = true;
+        return true;
+    }
+
+    // "{$wpdb->base_prefix}{$blog_id}_capabilities" (serialized arrays).
+    $pattern = $wpdb->esc_like( $wpdb->base_prefix ) . '%\_capabilities';
+    // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching -- static-map cache is sufficient for this gated existence check.
+    $meta_rows = $wpdb->get_col(
+        $wpdb->prepare(
+            "SELECT meta_value FROM {$wpdb->usermeta}
+             WHERE user_id = %d
+               AND meta_key LIKE %s",
+            $user_id,
+            $pattern
+        )
+    );
+    // phpcs:enable WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
+    foreach ( $meta_rows as $serialized ) {
+        $caps = maybe_unserialize( $serialized );
+        if ( is_array( $caps ) && (
+            ! empty( $caps['general_translation_editor'] ) ||
+            ! empty( $caps['locale_manager'] ) ||
+            ! empty( $caps['translation_editor'] )
+        ) ) {
+            $cache[ $user_id ] = true;
+            return true;
+        }
+    }
+
+    $cache[ $user_id ] = false;
+    return false;
+    }
 
 /**

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/settings-edit.php

@@ -268 +268 @@
         </td>
     </tr>
+    <?php if ( wporg_translate_user_is_validator_anywhere( get_current_user_id() ) ) : ?>
+    <tr>
+        <th>
+            <h4><?php esc_html_e( 'Validator settings', 'glotpress' ); ?></h4>
+        </th>
+    </tr>
+    <tr>
+        <th>
+            <label for="default_sort[hide_validator_topbar]">
+                <?php esc_html_e( 'Hide the validation top bar in the translation editor', 'glotpress' ); ?>
+            </label>
+        </th>
+        <td>
+            <input type="hidden" name="default_sort[hide_validator_topbar]" value="off" />
+            <input
+                type="checkbox"
+                id="default_sort[hide_validator_topbar]"
+                name="default_sort[hide_validator_topbar]"
+                <?php gp_checked( 'on' === gp_array_get( $gp_default_sort, 'hide_validator_topbar', 'off' ) ); ?>
+            />
+        </td>
+    </tr>
+    <?php endif; ?>
 </table>