Changeset 14975

Timestamp:

07/16/2026 03:40:20 PM (8 weeks ago)

Author:

obenland

Message:

Theme Directory: Don't auto-approve when Trac ticket creation failed

Closes ​https://github.com/WordPress/wordpress.org/pull/715.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory

Files:

• class-wporg-themes-upload.php (modified) (2 diffs)
• tests/Trac_Ticket_Creation_Failure_Test.php (added)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -795 +795 @@
                                         sprintf(
                                                 /* translators: %s: mailto link */
-                                                __( 'There was an error creating a Trac ticket for your theme, please report this error to %s', 'wporg-themes' ),
+                                                __( 'There was an error creating a Trac ticket for your theme. This is usually temporary, so please wait a few minutes and try uploading again. If the error persists, report it to %s.', 'wporg-themes' ),
                                                 '<a href="mailto:themes@wordpress.org">themes@wordpress.org</a>'
                                         )
@@ -1351 +1351 @@
                         ) );
 
-                        // Themes team auto-approves theme-updates. Note that this only applies to new
-                        // ticket creation, so it won't happen on themes with existing outstanding tickets.
-                        if ( $this->trac_ticket->priority == 'theme update' ) {
+                        /*
+                         * Themes team auto-approves theme-updates. Note that this only applies to new
+                         * ticket creation, so it won't happen on themes with existing outstanding tickets.
+                         *
+                         * Skipped when ticket creation failed, as there's no ticket to act upon.
+                         */
+                        if ( $ticket_id && 'theme update' === $this->trac_ticket->priority ) {
                                 $release_delay = wporg_themes_get_release_cooldown_delay( $this->theme_slug );
                                 if ( $release_delay ) {