Changeset 14982

Timestamp:

07/20/2026 08:45:02 PM (3 months ago)

Author:

obenland

Message:

Trac: Modernize wp-trac.js for jQuery 3 / Trac 1.6 and tidy ticket styling

Closes ​https://github.com/WordPress/wordpress.org/pull/722.

Location:

sites/trunk/wordpress.org/public_html/style/trac

Files:

• wp-trac.css (modified) (3 diffs)
• wp-trac.js (modified) (7 diffs)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.css

@@ -399 +399 @@
         background: #f9f9f9;
         border: 1px solid #ccc;
-}
-#content.ticket .ticketdraft {
-        border: 1px solid #ccc;
+        padding: 0;
 }
 #ticket > h2 {
@@ -764 +762 @@
 }
 div.trac-content {
-        -webkit-border-radius: 3px;
-        border-radius: 3px;
+        border: none;
+        margin: 0;
 }
 .foldable :link, .foldable :visited {
-        -webkit-border-radius: 3px;
-        border-radius: 3px;
+        border: none;
 }
 .foldable a:hover {
@@ -1098 +1095 @@
 #propertyform[action*="/newticket"] #properties table.trac-properties > tbody > tr > td#focuses {
         padding-left: 58px;
+}
+#propertyform[action*="/newticket"] ~ #commits {
+        display: none;
 }
 #propertyform > .buttons {

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -1548 +1548 @@
                                         url: endpoint + '?trac-notifications=' + ticket,
                                         xhrFields: { withCredentials: true }
-                                }).success( function( data ) {
+                                }).done( function( data ) {
                                         if ( data.success ) {
                                                 render( data.data['notifications-box'] );
@@ -1684 +1684 @@
                                                 'tickets' : tickets
                                         }
-                                }).success( function( data ) {
+                                }).done( function( data ) {
                                         if ( ! data.success ) {
                                                 return;
@@ -1791 +1791 @@
                                                 + ( authenticated ? '&authenticated=1' : '' )
                                                 + ( ( authenticated && 'URL' in window ) ? '&_lastmod=' + ( new URL( jQuery('a.timeline').last().prop('href') ) ).searchParams.get( 'from' ) : '' )
-                                ).success( function( data ) {
+                                ).done( function( data ) {
                                         // Update the number
                                         container.find( 'h3 .trac-count' ).removeClass( 'hidden' ).find( 'span' ).text( data.length );
@@ -1861 +1861 @@
                                                         + '&author=' + user
                                                         + ( authenticated ? '&authenticated=1' : '' )
-                                        ).success( function( ticketList ) {
+                                        ).done( function( ticketList ) {
                                                 document.location = document.location.toString() +
                                                         ( document.location.search ? '&' : '?' ) +
@@ -2166 +2166 @@
                 }() ),
 
-                patchTracFor122Changes: function() {
-                        // TODO: This needs to be removed, the Trac assets on s.w.org are probably outdated and need updating.
-                        console.log( "wp-trac: Applying compat patches for Trac 1.2.2" );
-                        // From Trac 1.2.2 threaded_comments.js:
-                        window.applyCommentsOrder = window.applyCommentsOrder || function() {}
-
-                        // Add Params to s.w.org scripts and stylesheets when loaded dynamically.
+                addDynamicAssetCacheBuster: function() {
+                        // Add cache-busting params to s.w.org scripts and stylesheets when loaded dynamically.
                         var cache_buster = jQuery('script[src^="https://s.w.org"][src*="v="]').attr('src');
                         if ( cache_buster ) {
@@ -2191 +2186 @@
                                 return oldLoadStylesheet( maybe_add_cache_buster( href ) );
                         }
-
-                        // From Trac 1.2.2 trac.js:
-                        $.loadScript                = $.loadScript                || function() {}
-                        $.fn.exclusiveOnClick       = $.fn.exclusiveOnClick       || function() {}
-                        $.fn.addSelectAllCheckboxes = $.fn.addSelectAllCheckboxes || function() {}
-                        $.fn.disableOnSubmit        = $.fn.disableOnSubmit        || function() {}
-                        $.fn.disableSubmit          = $.fn.disableSubmit          || function() {}
                 },
 
@@ -2211 +2199 @@
         // Perform this as soon as this file loads.
         wpTrac.disableTracAutoFocus();
-        wpTrac.patchTracFor122Changes();
+        wpTrac.addDynamicAssetCacheBuster();
 
 })(jQuery);