Changeset 15099

Timestamp:

08/25/2026 07:34:08 PM (12 hours ago)

Author:

obenland

Message:

Trac PRs: Avoid a PHP Warning when a PR no longer references a Trac ticket.

File:

• sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/webhook.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/webhook.php

@@ -70 +70 @@
                 // Step 2. Is that Trac Ticket still what we expect?
                 $matched_existing_ref = false;
-                foreach ( $existing_refs as $ref ) {
-                        if (
-                                $ref->trac === $pr_data->trac_ticket[0] &&
-                                $ref->ticket === $pr_data->trac_ticket[1]
-                        ) {
-                                $matched_existing_ref = true;
+                if ( $pr_data->trac_ticket ) {
+                        foreach ( $existing_refs as $ref ) {
+                                if (
+                                        $ref->trac === $pr_data->trac_ticket[0] &&
+                                        $ref->ticket === $pr_data->trac_ticket[1]
+                                ) {
+                                        $matched_existing_ref = true;
+                                }
                         }
                 }