Changeset 15121 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-topic-resolution/inc/class-plugin.php

Timestamp:

09/01/2026 07:01:20 PM (5 weeks ago)

Author:

obenland

Message:

Support Forums: use the topic ID passed to user_can_resolve()

Closes ​https://github.com/WordPress/wordpress.org/pull/856.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-topic-resolution/inc/class-plugin.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-topic-resolution/inc/class-plugin.php

@@ -265 +265 @@
          */
         public function topic_resolution_handler( $action = '' ) {
-                if ( ! $this->is_enabled_on_forum() ) {
-                        return false;
-                }
-
                 // Bail if the action isn't meant for this function.
                 if ( $action != 'wporg_bbp_topic_resolution' ) {
@@ -284 +280 @@
                 $user_id    = get_current_user_id();
                 $resolution = $_POST[ self::META_KEY ];
+
+                // Resolution must be enabled on the topic's forum, not on the one being viewed.
+                if ( $topic && ! $this->is_enabled_on_forum( bbp_get_topic_forum_id( $topic->ID ) ) ) {
+                        return false;
+                }
 
                 // Check for empty topic id.
@@ -510 +511 @@
          */
         public function user_can_resolve( $user_id, $topic_id ) {
-                $post     = false;
-                $topic_id = bbp_get_topic_id();
-                if ( $topic_id ) {
-                        $post = get_post( $topic_id );
-                }
+                // Authorize against the requested topic, only falling back to the displayed one.
+                $topic_id = bbp_get_topic_id( $topic_id );
+                $post     = $topic_id ? bbp_get_topic( $topic_id ) : false;
 
                 if ( $user_id && $post && ( user_can( $user_id, 'moderate', $topic_id ) || $user_id == $post->post_author ) ) {