Changeset 1527

Timestamp:

04/30/2015 11:31:29 PM (9 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Prevent brief display of search bar on page load before it gets hidden (while maintaining no-JS support). Fixes #763.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer

Files:

• functions.php (modified) (3 diffs)
• js/search.js (modified) (1 diff)
• searchform.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/functions.php

@@ -87 +87 @@
     add_action( 'pre_get_posts', __NAMESPACE__ . '\\pre_get_posts' );
     add_action( 'wp_enqueue_scripts', __NAMESPACE__ . '\\theme_scripts_styles' );
+    add_action( 'wp_head', __NAMESPACE__ . '\\header_js' );
     add_action( 'add_meta_boxes', __NAMESPACE__ . '\\rename_comments_meta_box', 10, 2 );
 
@@ -103 +104 @@
     add_filter( 'breadcrumb_trail_items',  __NAMESPACE__ . '\\breadcrumb_trail_items', 10, 2 );
 
-    add_filter( 'wp_parser_skip_duplicate_hooks', '__return_true' ); 
+    add_filter( 'wp_parser_skip_duplicate_hooks', '__return_true' );
 
 }
@@ -244 +245 @@
 }
 
+/**
+ * Outputs JavaScript intended to appear in the head of the page.
+ */
+function header_js() {
+    // Output CSS to hide markup with the class 'hide-if-js'. Ensures the markup is visible if JS is not present.
+    echo "<script type=\"text/javascript\">jQuery( '<style>.hide-if-js { display: none; }</style>' ).appendTo( 'head' );</script>\n";
+}
+
 function theme_scripts_styles() {
     wp_enqueue_style( 'dashicons' );

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/search.js

@@ -15 +15 @@
         }
     }
-
-    // Toggle search bar on page load (it's shown by default).
-    toggle_search_bar();
 
     // Toggle search bar when icon is clicked.

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/searchform.php

@@ -6 +6 @@
  */
 ?>
-<div class="search-section section clear">
+<div class="search-section section clear <?php if ( ! is_page( 'reference' ) ) { echo 'hide-if-js'; } ?>">
 
 <?php if ( is_search() ) { ?>