Changeset 1540

Timestamp:

05/04/2015 08:19:43 PM (9 years ago)

Author:

iandunn

Message:

WordCamp Post Types: Maintain boolean values during str_to_bool() conversion.

This fixes a bug introduced in r1539 where a boolean passed to this function would be unintentionally converted to a string, but later treated as though it might still be a boolean.

See #1016
See ​https://wordpress.slack.com/archives/meta/p1430769561000761

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/wc-post-types.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wc-post-types/wc-post-types.php

@@ -829 +829 @@
     /**
      * Convert a string representation of a boolean to an actual boolean
+     *
+     * @param string|bool
+     *
+     * @return bool
      */
     function str_to_bool( $value ) {
-        $value = strtolower( trim( $value ) );
-
-        if ( true === $value || in_array( $value, array( 'yes', 'true', '1' ) ) ) {
+        if ( true === $value ) {
+            return true;
+        }
+
+        if ( in_array( strtolower( trim( $value ) ), array( 'yes', 'true', '1' ) ) ) {
             return true;
         }