Changeset 1587 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

Timestamp:

05/15/2015 11:34:10 PM (11 years ago)

Author:

iandunn

Message:

WordCamp Post Type: Avoid undefined index notices when restoring revisions.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -103 +103 @@
             return;
 
+        // Don't add/remove meta on trash, untrash, restore, etc
+        if ( empty( $_POST['action'] ) || 'editpost' != $_POST['action'] ) {
+            return;
+        }
+
         // WordCamp post type only
+        // todo return early if not type instead of indenting
         if ( WCPT_POST_TYPE_ID == get_post_type() ) {
             // If the venue address was changed, update its coordinates
@@ -588 +594 @@
 
         // Check pending posts
+        // todo return early if not wordcamp post type instead of checking in both of these conditions
         if ( WCPT_POST_TYPE_ID == $post_data['post_type'] && 'pending' == $post_data['post_status'] && absint( $_POST['post_ID'] ) > $min_site_id ) {
             foreach( $required_pending_fields as $field ) {
@@ -601 +608 @@
 
         // Check published posts
-        if ( WCPT_POST_TYPE_ID == $post_data['post_type'] && 'publish' == $post_data['post_status'] && absint( $_POST['post_ID'] ) > $min_site_id ) {
+        if ( WCPT_POST_TYPE_ID == $post_data['post_type'] && 'publish' == $post_data['post_status'] && isset( $_POST['post_ID'] ) && absint( $_POST['post_ID'] ) > $min_site_id ) {
             foreach( $required_publish_fields as $field ) {
                 $value = $_POST[ wcpt_key_to_str( $field, 'wcpt_' ) ];