Changeset 1588 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

Timestamp:

05/15/2015 11:36:41 PM (11 years ago)

Author:

iandunn

Message:

WordCamp Post Type: Return early when saving other post types.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -567 +567 @@
      */
     public function require_complete_meta_to_publish_wordcamp( $post_data, $post_data_raw ) {
+        if ( WCPT_POST_TYPE_ID != $post_data['post_type'] ) {
+            return $post_data;
+        }
+
         // The ID of the last site that was created before this rule went into effect, so that we don't apply the rule retroactively.
         $min_site_id = apply_filters( 'wcpt_require_complete_meta_min_site_id', '2416297' );
@@ -594 +598 @@
 
         // Check pending posts
-        // todo return early if not wordcamp post type instead of checking in both of these conditions
-        if ( WCPT_POST_TYPE_ID == $post_data['post_type'] && 'pending' == $post_data['post_status'] && absint( $_POST['post_ID'] ) > $min_site_id ) {
+        if ( 'pending' == $post_data['post_status'] && absint( $_POST['post_ID'] ) > $min_site_id ) {
             foreach( $required_pending_fields as $field ) {
                 $value = $_POST[ wcpt_key_to_str( $field, 'wcpt_' ) ];
@@ -608 +611 @@
 
         // Check published posts
-        if ( WCPT_POST_TYPE_ID == $post_data['post_type'] && 'publish' == $post_data['post_status'] && isset( $_POST['post_ID'] ) && absint( $_POST['post_ID'] ) > $min_site_id ) {
+        if ( 'publish' == $post_data['post_status'] && isset( $_POST['post_ID'] ) && absint( $_POST['post_ID'] ) > $min_site_id ) {
             foreach( $required_publish_fields as $field ) {
                 $value = $_POST[ wcpt_key_to_str( $field, 'wcpt_' ) ];