Changeset 1782

Timestamp:

07/23/2015 08:08:28 PM (9 years ago)

Author:

ocean90

Message:

Translate: Loop over locales instead of grouping them in SQL.

see #994.

File:

• sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-routes/cli/wporg-update-cached-data.php (modified) (4 diffs)

sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-routes/cli/wporg-update-cached-data.php

@@ -9 +9 @@
     public $cache_group = 'wporg-translate';
 
+    private $locales = array();
+
     public function run() {
+        $this->locales = GP::$translation_set->existing_locales();
+
         $this->update_contributors_count();
         $this->update_translation_status();
@@ -20 +24 @@
         global $gpdb;
 
-        $results = $gpdb->get_results( "
-            SELECT ts.locale, COUNT( DISTINCT( t.user_id ) ) AS count
-            FROM $gpdb->translations t
-                INNER JOIN $gpdb->translation_sets AS ts
-                    ON ts.id = t.translation_set_id
-            WHERE
-                ( t.status = 'current' || t.status = 'old' )
-                AND t.user_id IS NOT NULL
-                AND t.user_id <> '0'
-            GROUP BY ts.locale
-        " );
+        $counts = array();
+        foreach ( $this->locales as $locale ) {
+            $result = $gpdb->get_var( $gpdb->prepare( "
+                SELECT COUNT( DISTINCT( t.user_id ) ) AS count
+                FROM {$gpdb->translations} t
+                    INNER JOIN {$gpdb->translation_sets} AS ts
+                        ON ts.id = t.translation_set_id
+                WHERE
+                    ( t.status = 'current' || t.status = 'old' )
+                    AND t.user_id IS NOT NULL
+                    AND t.user_id <> '0'
+                    AND ts.locale = %s
+            ",  $locale ) );
 
-        $counts = array();
-        if ( $results ) {
-            foreach ( $results as $result ) {
-                $counts[ $result->locale ] = $result->count;
+            if ( $result ) {
+                $counts[ $locale ] = $result;
+            } else {
+                $counts[ $locale ] = 0;
             }
         }
@@ -48 +54 @@
         global $gpdb;
 
-        $locales = GP::$translation_set->existing_locales();
         $projects = GP::$project->many( "
             SELECT *
-            FROM $gpdb->projects
+            FROM {$gpdb->projects}
             WHERE
                 path LIKE 'wp/dev%'
@@ -58 +63 @@
         $translation_status = array();
         foreach ( $projects as $project ) {
-            foreach ( $locales as $locale ) {
+            foreach ( $this->locales as $locale ) {
                 $set = GP::$translation_set->by_project_id_slug_and_locale(
                     $project->id,