Changeset 1870

Timestamp:

09/11/2015 04:48:04 AM (9 years ago)

Author:

dd32

Message:

Translate: Don't log a warning twice in a single request. This can occur when a translation editor triggers a warning as we both save and approve the string in one move.

See #1229

File:

• sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-log-warnings-to-slack.php (modified) (2 diffs)

sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-log-warnings-to-slack.php

@@ -9 +9 @@
 
     var $channel = '#polyglots-warnings';
+
+    // Holds the list of Translation ID's which have been notified about in this process
+    var $warned = array();
 
     function __construct() {
@@ -58 +61 @@
      */
     function process_translation_warning( $translation ) {
+        // Avoid processing a specific translation twice
+        if ( isset( $this->warned[ $translation->id ] ) ) {
+            return;
+        }
+        $this->warned[ $translation->id ] = true;
+
+
         $original = GP::$original->get( $translation->original_id );
         $set = GP::$translation_set->get( $translation->translation_set_id );