Changeset 1955

Timestamp:

10/10/2015 07:21:00 PM (11 years ago)

Author:

ocean90

Message:

Trac: Move JavaScript logic for contributor labels into wp-trac.js.

Fixes #1326.

Location:

sites/trunk

Files:

• trac.wordpress.org/templates/core/site-specific.html (modified) (4 diffs)
• wordpress.org/public_html/style/trac/wp-trac.js (modified) (3 diffs)

sites/trunk/trac.wordpress.org/templates/core/site-specific.html

@@ -14 +14 @@
 <div id="report-popup"></div>
 <script>
-(function($){
-var titles = {
+var wpTracContributorLabels = {
         matt: 'Project Lead',
         markjaquith: 'Lead Developer',
@@ -24 +23 @@
 
         ocean90: 'Core Committer',
-        sergeybiryukov: 'Core Committer',
+        SergeyBiryukov: 'Core Committer',
         johnbillion: 'Core Committer',
         pento: 'Core Committer',
@@ -44 +43 @@
         iandstewart: 'Themes Committer',
         karmatosed: 'Themes Committer',
-        drewapicture: 'Docs Committer',
+        DrewAPicture: 'Docs Committer',
 
         ryan: 'Lead Developer',
@@ -52 +51 @@
 };
 
-$('h3.change .profile-link').each( function() {
-        var el = $(this);
-        user = el.attr('href').split('/').pop().toLowerCase();
-        if ( user in titles ) {
-                el.after( ' <span class="contributor-label">(' + titles[ user ] + ')</span>' );
-        }
-});
-})(jQuery);
 </script>
 </body>

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -50 +50 @@
                                 wpTrac.nonGardeners();
                         }
+
+                        if ( 'undefined' !== typeof wpTracContributorLabels ) {
+                                wpTrac.showContributorLabels( wpTracContributorLabels );
+                        }
+
                         if ( ! $(document.body).hasClass( 'plugins' ) ) {
                                 wpTrac.workflow.init();
@@ -59 +64 @@
                 },
 
+                showContributorLabels: function( labels ) {
+                        $( 'h3.change .username' ).each( function() {
+                                var $el = $( this ),
+                                        username = $el.data( 'username' );
+
+                                if ( username in labels ) {
+                                        $el.parent( 'a.profile-link' ).after( ' <span class="contributor-label">(' + labels[ username ] + ')</span>' );
+                                }
+                        });
+                },
                 // These ticket hacks need to be re-run after ticket previews.
                 postPreviewHacks: function() {
@@ -74 +89 @@
                                 }
                                 appendTo = li.parent().parent(); // div.change
-                                image = new Image;
+                                image = new Image();
                                 image.src = href;
                                 image.onload = function() {