Changeset 1993

Timestamp:

10/18/2015 07:33:30 PM (10 years ago)

Author:

ocean90

Message:

Trac: Don't link reserved names.

Props DrewAPicture.
Fixes #1344.
See #830.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -41 +41 @@
     gardenerKeywordList = [ 'commit', 'early', 'i18n-change', 'good-first-bug' ];
 
+    reservedTerms = [
+        'access', 'deprecated', 'global', 'ignore', 'internal', 'link', 'method',
+        'package', 'return','see', 'since', 'subpackage', 'todo', 'type', 'var'
+    ];
+
     wpTrac = {
 
@@ -93 +98 @@
                 if ( mentionsRegEx.test( $comment ) ) {
                     $comment = $comment.replace( mentionsRegEx, function( match, username ) {
+                        if ( -1 !== $.inArray( username, reservedTerms ) ) {
+                            return match;
+                        }
+
                         var meClass = ( username === wpTrac.currentUser ) ? ' me' : '';
                         return ' <a class="mention' + meClass + '" href="https://profiles.wordpress.org/' + username + '">@' + username + '</a>';