Changeset 2107 for sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-stats-overview.php

Timestamp:

11/22/2015 06:47:02 PM (9 years ago)

Author:

ocean90

Message:

Translate, Stats: Avoid a division by zero warning and use the same calculation for $percent_complete as on project pages.

File:

• sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-stats-overview.php (modified) (2 diffs)

sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-stats-overview.php

@@ -74 +74 @@
             }
 
-            $translation_locale_statuses[ $locale_key ][ $set->path ] = floor( (float) $set->percent_complete );
+            /*
+             * > 50% round down, so that a project with all strings except 1 translated shows 99%, instead of 100%.
+             * < 50% round up, so that a project with just a few strings shows 1%, instead of 0%.
+             */
+            $percent_complete = (float) $set->percent_complete;
+            $percent_complete = ( $percent_complete > 50 ) ? floor( $percent_complete ) : ceil( $percent_complete );
+            $translation_locale_statuses[ $locale_key ][ $set->path ] = $percent_complete;
+
             if ( ! isset( $translation_locale_statuses[ $locale_key ]['waiting'] ) ) {
                 $translation_locale_statuses[ $locale_key ]['waiting'] = 0;
@@ -111 +118 @@
         foreach ( $translation_locale_statuses as $locale => $sets ) {
             unset( $sets['waiting'] );
-            $translation_locale_complete[ $locale ] = round( array_sum( $sets ) / count( $sets ), 3 );
+            $sets_count = count( $sets );
+            if ( $sets_count ) {
+                $translation_locale_complete[ $locale ] = round( array_sum( $sets ) / $sets_count, 3 );
+            } else {
+                $translation_locale_complete[ $locale ] = 0;
+            }
         }
         unset( $locale, $sets );