Changeset 2166 for sites/trunk/common/includes/wporg-sso/wp-plugin.php

Timestamp:

12/06/2015 04:46:41 PM (9 years ago)

Author:

stephdau

Message:

WPORG SSO (login.wordpress.org): properly url encoding redirect_to query string parameter.

File:

• sites/trunk/common/includes/wporg-sso/wp-plugin.php (modified) (2 diffs)

sites/trunk/common/includes/wporg-sso/wp-plugin.php

@@ -45 +45 @@
             if ( preg_match( '/\/wp-signup\.php$/', $this->script ) ) {
                 // If we're on any WP signup screen, redirect to the SSO host one,respecting the user's redirect_to request
-                $this->_safe_redirect( add_query_arg( 'redirect_to', $redirect_req, $this->sso_signup_url ) );
+                $this->_safe_redirect( add_query_arg( 'redirect_to', urlencode( $redirect_req ), $this->sso_signup_url ) );
             
             } else if ( self::SSO_HOST !== $this->host ) {
@@ -59 +59 @@
                     
                     // Pay extra attention to the post-process redirect_to
-                    $redirect_to_sso_login = add_query_arg( 'redirect_to', $redirect_req, $redirect_to_sso_login );
+                    $redirect_to_sso_login = add_query_arg( 'redirect_to', urlencode( $redirect_req ), $redirect_to_sso_login );
                     
                     // And actually redirect to the SSO login