Changeset 2196 for sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-rosetta-roles/wporg-rosetta-roles.php

Timestamp:

12/17/2015 11:59:45 AM (9 years ago)

Author:

ocean90

Message:

Translate: Use the new translation_editors table to retrieve the project ID access list of a user.

See #1240.

File:

• sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-rosetta-roles/wporg-rosetta-roles.php (modified) (5 diffs)

sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-rosetta-roles/wporg-rosetta-roles.php

@@ -22 +22 @@
 
     /**
-     * Holds the role of an approver.
-     *
-     * @var string
-     */
-    public $approver_role = 'translation_editor';
+     * Database table for translation editors.
+     */
+    const TRANSLATION_EDITORS_TABLE = 'translate_translation_editors';
+
+    /**
+     * Role of a per project translation editor.
+     */
+    const TRANSLATION_EDITOR_ROLE = 'translation_editor';
+
+    /**
+     * Role of a general translation editor.
+     */
+    const GENERAL_TRANSLATION_EDITOR_ROLE = 'general_translation_editor';
 
     /**
@@ -40 +48 @@
     public function __construct() {
         parent::__construct();
+
+        $GLOBALS['gpdb']->wporg_translation_editors = self::TRANSLATION_EDITORS_TABLE;
+
         $this->add_filter( 'pre_can_user', array( 'args' => 2, 'priority' => 9 ) );
         $this->add_action( 'project_created' );
@@ -152 +163 @@
      */
     public function is_approver_for_locale( $user_id, $locale_slug ) {
+        static $cache = null;
+
+        if ( null === $cache ) {
+            $cache = array();
+        }
+
+        if ( isset( $cache[ $user_id ][ $locale_slug ] ) ) {
+            return $cache[ $user_id ][ $locale_slug ];
+        }
+
         if ( ! class_exists( 'BP_Roles' ) ) {
             require_once( BACKPRESS_PATH . 'class.bp-roles.php' );
@@ -174 +195 @@
         $user->get_role_caps();
 
-        return $user->has_cap( $this->approver_role );
-
+        $is_approver = $user->has_cap( self::TRANSLATION_EDITOR_ROLE ) || $user->has_cap( self::GENERAL_TRANSLATION_EDITOR_ROLE );
+
+        if ( ! isset( $cache[ $user_id ] ) ) {
+            $cache[ $user_id ] = array();
+        }
+
+        $cache[ $user_id ][ $locale_slug ] = $is_approver;
+        return $is_approver;
     }
 
@@ -191 +218 @@
      */
     public function get_project_id_access_list( $user_id, $locale_slug, $include_children = false ) {
-        if ( ! class_exists( 'BP_Roles' ) ) {
-            require_once( BACKPRESS_PATH . 'class.bp-roles.php' );
-        }
-        if ( ! class_exists( 'BP_User' ) ) {
-            require_once( BACKPRESS_PATH . 'class.bp-user.php' );
-        }
-
-        $user = new BP_User( $user_id );
-
-        // Get blog prefix of the associated Rosetta site.
-        if ( ! $blog_prefix = $this->get_blog_prefix( $locale_slug ) ) {
-            return false;
-        }
-
-        // Get IDs of projects which the user can approve.
-        $meta_key = $blog_prefix . $this->project_access_meta_key;
-        if ( empty( $user->$meta_key ) || ! is_array( $user->$meta_key ) ) {
-            return false;
-        }
-
-        $project_access_list = $user->$meta_key;
+        global $gpdb;
+        static $cache = null;
+
+        if ( null === $cache ) {
+            $cache = array();
+        }
+
+        if ( isset( $cache[ $user_id ][ $locale_slug ] ) ) {
+            $project_access_list = $cache[ $user_id ][ $locale_slug ];
+        } else {
+            $project_access_list = $gpdb->get_col( $gpdb->prepare( "
+                SELECT project_id FROM
+                {$gpdb->wporg_translation_editors}
+                WHERE user_id = %d AND locale = %s
+            ", $user_id, $locale_slug ) );
+
+            if ( ! isset( $cache[ $user_id ] ) ) {
+                $cache[ $user_id ] = array();
+            }
+
+            $cache[ $user_id ][ $locale_slug ] = $project_access_list;
+        }
+
+        if ( ! $project_access_list ) {
+            return false;
+        }
+
+        if ( in_array( '0', $project_access_list, true ) ) {
+            $project_access_list = array( 'all' );
+        }
 
         // If we don't want the children, or the user has access to all projects.