Changeset 2262

Timestamp:

01/10/2016 12:16:28 AM (9 years ago)

Author:

ocean90

Message:

Translate: Update roles plugin (WP version) to use the new translation_editors table.

See #1240, #1352.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-rosetta-roles/wporg-gp-rosetta-roles.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-rosetta-roles/wporg-gp-rosetta-roles.php

@@ -29 +29 @@
 
     /**
-     * Holds the meta key of the project access list.
-     *
-     * @var string
-     */
-    public $project_access_meta_key = 'translation_editor_project_access_list';
+     * Database table for translation editors.
+     */
+    const TRANSLATION_EDITORS_TABLE = 'translate_translation_editors';
+
+    /**
+     * Role of a per project translation editor.
+     */
+    const TRANSLATION_EDITOR_ROLE = 'translation_editor';
+
+    /**
+     * Role of a general translation editor.
+     */
+    const GENERAL_TRANSLATION_EDITOR_ROLE = 'general_translation_editor';
 
     /**
@@ -39 +47 @@
      */
     public function __construct() {
+        $GLOBALS['wpdb']->wporg_translation_editors = self::TRANSLATION_EDITORS_TABLE;
+
         add_filter( 'gp_pre_can_user', array( $this, 'pre_can_user' ), 9 , 2 );
         add_action( 'gp_project_created', array( $this, 'project_created' ) );
@@ -144 +154 @@
      */
     public function is_approver_for_locale( $user_id, $locale_slug ) {
+        static $cache = null;
+
+        if ( null === $cache ) {
+            $cache = array();
+        }
+
+        if ( isset( $cache[ $user_id ][ $locale_slug ] ) ) {
+            return $cache[ $user_id ][ $locale_slug ];
+        }
+
+        if ( ! isset( $cache[ $user_id ] ) ) {
+            $cache[ $user_id ] = array();
+        }
+
         // Get blog prefix of the associated Rosetta site.
         if ( ! $blog_prefix = $this->get_blog_prefix( $locale_slug ) ) {
+            $cache[ $user_id ][ $locale_slug ] = false;
             return false;
         }
@@ -151 +176 @@
         $user = get_user_by( 'id', $user_id );
 
-        // Check if current user has the approver role.
-        $user->cap_key = $blog_prefix . 'capabilities';
-        $user->caps = &$user->{$user->cap_key};
-        if ( ! is_array( $user->caps ) ) {
-            $user->caps = array();
-        }
-        $user->get_role_caps();
-
-        return $user->has_cap( $this->approver_role );
+        $cap_key = $blog_prefix . 'capabilities';
+        if ( ! isset( $user->{$cap_key} ) ) {
+            $cache[ $user_id ][ $locale_slug ] = false;
+            return false;
+        }
+
+        $is_approver = in_array( self::TRANSLATION_EDITOR_ROLE, $user->$cap_key ) || in_array( self::GENERAL_TRANSLATION_EDITOR_ROLE, $user->$cap_key );
+        $cache[ $user_id ][ $locale_slug ] = $is_approver;
+
+        return $is_approver;
     }
 
@@ -175 +201 @@
      */
     public function get_project_id_access_list( $user_id, $locale_slug, $include_children = false ) {
-        $user = get_user_by( 'id', $user_id );
-
-        // Get blog prefix of the associated Rosetta site.
-        if ( ! $blog_prefix = $this->get_blog_prefix( $locale_slug ) ) {
-            return false;
-        }
-
-        // Get IDs of projects which the user can approve.
-        $meta_key = $blog_prefix . $this->project_access_meta_key;
-        if ( empty( $user->$meta_key ) || ! is_array( $user->$meta_key ) ) {
-            return false;
-        }
-
-        $project_access_list = $user->$meta_key;
+        global $wpdb;
+        static $cache = null;
+
+        if ( null === $cache ) {
+            $cache = array();
+        }
+
+        if ( isset( $cache[ $user_id ][ $locale_slug ] ) ) {
+            $project_access_list = $cache[ $user_id ][ $locale_slug ];
+        } else {
+            $project_access_list = $wpdb->get_col( $wpdb->prepare( "
+                SELECT project_id FROM
+                {$wpdb->wporg_translation_editors}
+                WHERE user_id = %d AND locale = %s
+            ", $user_id, $locale_slug ) );
+
+            if ( ! isset( $cache[ $user_id ] ) ) {
+                $cache[ $user_id ] = array();
+            }
+
+            $cache[ $user_id ][ $locale_slug ] = $project_access_list;
+        }
+
+        if ( ! $project_access_list ) {
+            return false;
+        }
+
+        if ( in_array( '0', $project_access_list, true ) ) {
+            $project_access_list = array( 'all' );
+        }
 
         // If we don't want the children, or the user has access to all projects.