Changeset 2263

Timestamp:

01/10/2016 12:18:50 AM (9 years ago)

Author:

ocean90

Message:

Translate: Use the wp_default_scripts action for replacing the default editor script.

Prevents missing localized data like $gp_editor_options.

See #1352.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-js-warnings/wporg-gp-js-warnings.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-js-warnings/wporg-gp-js-warnings.php

@@ -14 +14 @@
  * - Translate the warning strings
  * - Match warning error strings between GlotPress & this plugin?
- *
- * @author dd32
  */
 class WPorg_GP_JS_Translation_Warnings {
 
     function __construct() {
-        add_action( 'wp_print_scripts', array( $this, 'replace_editor_with_our_own' ), 100 );
+        add_action( 'wp_default_scripts', array( $this, 'replace_editor_with_our_own' ), 11 );
     }
 
@@ -27 +25 @@
      *
      * This allows us to be output whenever `gp-editor` is.
+     *
+     * @param WP_Scripts $scripts WP_Scripts object.
      */
-    function replace_editor_with_our_own() {
-        $query = wp_scripts()->query( 'gp-editor', 'registered' );
+    function replace_editor_with_our_own( $scripts ) {
+        $query = $scripts->query( 'gp-editor', 'registered' );
         if ( ! $query ) {
             return;
         }
 
-        wp_register_script( 'wporg-gp-editor', $query->src, $query->deps, $query->ver );
+        $scripts->add( 'wporg-gp-editor', $query->src, $query->deps, $query->ver );
         if ( isset( $query->extra['l10n'] ) ) {
-            wp_localize_script( 'wporg-gp-editor', $query->extra['l10n'][0], $query->extra['l10n'][1] );
+            $scripts->localize( 'wporg-gp-editor', $query->extra['l10n'][0], $query->extra['l10n'][1] );
         }
 
-        wp_deregister_script( 'gp-editor' );
-        wp_register_script( 'gp-editor', plugins_url( '/wporg-gp-js-warnings.js', __FILE__ ), array( 'wporg-gp-editor', 'jquery' ), '2015-11-14' );
+        $scripts->remove( 'gp-editor' );
+        $scripts->add( 'gp-editor', plugins_url( '/wporg-gp-js-warnings.js', __FILE__ ), array( 'wporg-gp-editor', 'jquery' ), '2015-11-14' );
     }