Changeset 2280

Timestamp:

01/12/2016 05:44:47 PM (9 years ago)

Author:

ocean90

Message:

Translate: Cache the output of GP::$translation_set->existing_locales() for the locales overview.

The underlying query can take up to 3 seconds. :-(

See #1352.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes

Files:

• cli/update-caches.php (modified) (2 diffs)
• routes/index.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/cli/update-caches.php

@@ -11 +11 @@
         $this->contributors_count();
         $this->translation_status();
+        $this->existing_locales();
     }
 
@@ -68 +69 @@
         WP_CLI::success( 'Translation status was updated.' );
     }
+
+    /**
+     * Update cache for existing locales.
+     *
+     * @subcommand existing-locales
+     */
+    public function existing_locales() {
+        $existing_locales = GP::$translation_set->existing_locales();
+
+        wp_cache_set( 'existing-locales', $existing_locales, $this->cache_group );
+        WP_CLI::success( 'Existing locales were updated.' );
+    }
 }

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-routes/routes/index.php

@@ -7 +7 @@
 class WPorg_GP_Route_Index extends GP_Route {
 
+    private $cache_group = 'wporg-translate';
+
     /**
      * Prints all exisiting locales as cards.
+     *
+     * Note: Cache gets refreshed via `WPorg_GP_CLI_Update_Caches`.
      */
     public function get_locales() {
+        $existing_locales = wp_cache_get( 'existing-locales', $this->cache_group );
+        if ( false === $existing_locales ) {
+            $existing_locales = array();
+        }
+
         $locales = array();
-        $existing_locales = GP::$translation_set->existing_locales();
         foreach ( $existing_locales as $locale ) {
             $locales[] = GP_Locales::by_slug( $locale );
@@ -19 +27 @@
         unset( $existing_locales );
 
-        $contributors_count = wp_cache_get( 'contributors-count', 'wporg-translate' );
+        $contributors_count = wp_cache_get( 'contributors-count', $this->cache_group );
         if ( false === $contributors_count ) {
             $contributors_count = array();
         }
 
-        $translation_status = wp_cache_get( 'translation-status', 'wporg-translate' );
+        $translation_status = wp_cache_get( 'translation-status', $this->cache_group );
         if ( false === $translation_status ) {
             $translation_status = array();