Changeset 2310

Timestamp:

01/18/2016 08:24:57 PM (8 years ago)

Author:

ocean90

Message:

Trac: Don't make action text inputs and select fields focusable until the corresponding action is focused.

Also allow action select fields to be clicked directly.

Props SergeyBiryukov.
Fixes #1521.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -333 +333 @@
             });
 
-            // Allow action text inputs to be clicked directly.
+            // Allow action text inputs and select fields to be clicked directly.
             $('#action')
-                .find('input[type=text]').enable().focus( function() {
+                .find('input[type=text], select').enable().focus( function() {
                     $(this).siblings('input[type=radio]').click();
                 }).end()
@@ -341 +341 @@
                 .find('div').has('select').find('input[type=radio]').change( function() {
                     $(this).siblings('select').enable();
+                });
+
+            // Hide action text inputs and select fields from keyboard, unless the corresponding action is focused.
+            $('#action')
+                .find('input[type=text], select').each( function() {
+                    $(this).attr('tabindex', '-1');
+                }).end()
+                .find('input').blur( function() {
+                    $(this).parent().find('input[type=text], select').attr('tabindex', '-1');
+                }).focus( function() {
+                    $(this).parent().find('input[type=text], select').removeAttr('tabindex');
                 });