Changeset 2331

Timestamp:

01/19/2016 10:03:13 PM (8 years ago)

Author:

iandunn

Message:

WordCamp Budgets: Move uploadModalTitle string into wcbLocalizedStrings.

It's generic enough to be used by all modules, so each module doesn't need to set a unique title.

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments

Files:

• includes/payment-request.php (modified) (1 diff)
• includes/wordcamp-budgets.php (modified) (1 diff)
• javascript/payment-requests.js (modified) (1 diff)
• javascript/wordcamp-budgets.js (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php

@@ -200 +200 @@
             wp_enqueue_script( 'wcb-attached-files' );
         }
-
-        wp_localize_script(
-            'payment-requests',
-            'wcpLocalizedStrings',      // todo merge into WordCampBudgets var
-            array(
-                'uploadModalTitle'  => __( 'Attach Supporting Documentation', 'wordcamporg' ),
-            )
-        );
     }
 

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/wordcamp-budgets.php

@@ -60 +60 @@
             'wcbLocalizedStrings',      // todo merge into WordCampBudgets var
             array(
+                'uploadModalTitle'  => __( 'Attach Supporting Documentation', 'wordcamporg' ),
                 'uploadModalButton' => __( 'Attach Files', 'wordcamporg' ),
             )

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/javascript/payment-requests.js

@@ -23 +23 @@
         registerEventHandlers : function() {
             var paymentCategory = $( '#payment_category' );
-            
+
             $( '#wcp_payment_details' ).find( 'input[name=payment_method]' ).change( wcb.togglePaymentMethodFields );
             paymentCategory.change( app.toggleOtherCategoryDescription );
             paymentCategory.trigger( 'change' );   // Set the initial state
-            $( '#wcp_files' ).find( 'a.wcp-insert-media' ).click( { title : wcpLocalizedStrings.uploadModalTitle }, wcb.showUploadModal );
+            $( '#wcp_files' ).find( 'a.wcp-insert-media' ).click( wcb.showUploadModal );
             $( '#wcp_mark_incomplete_checkbox' ).click( app.requireNotes );
         },

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/javascript/wordcamp-budgets.js

@@ -30 +30 @@
                 // Create the frame
                 app.fileUploadFrame = wp.media( {
-                    title: event.data.title,
+                    title: wcbLocalizedStrings.uploadModalTitle,
                     multiple: true,
                     button: {