Changeset 2342 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php

Timestamp:

01/20/2016 09:49:51 PM (11 years ago)

Author:

iandunn

Message:

WordCamp Budgets: Centralize file uploads for all modules.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php

@@ -387 +387 @@
          */
         protected function render_files_input( $post, $label, $name, $description = '' ) {
-                $files = get_posts( array(
-                        'post_parent'    => $post->ID,
-                        'post_type'      => 'attachment',
-                        'posts_per_page' => -1,
-                        'orderby'        => 'title',
-                        'order'          => 'ASC',
-                ) );
-
-                foreach ( $files as &$file ) {
-                        $file->filename = wp_basename( $file->guid );
-                        $file->url      = wp_get_attachment_url( $file->ID );
-                }
+                $files = WordCamp_Budgets::get_attached_files( $post );
+
+                wp_localize_script( 'wcb-attached-files', 'wcbAttachedFiles', $files ); // todo merge into wordcampBudgets var
 
                 require( dirname( __DIR__ ) . '/views/payment-request/input-files.php' );
@@ -765 +756 @@
 
                 // Attach existing files
-                $this->attach_existing_files( $post_id, $_POST );
-        }
-
+                remove_action( 'save_post', array( $this, 'save_payment' ), 10 ); // avoid infinite recursion
+                WordCamp_Budgets::attach_existing_files( $post_id, $_POST );
+                add_action( 'save_post', array( $this, 'save_payment' ), 10, 2 );
+        }
+
+        /**
+         * Add log entries when the post status changes
+         *
+         * @param string  $new
+         * @param string  $old
+         * @param WP_Post $post
+         */
         public function transition_post_status( $new, $old, $post ) {
                 if ( $post->post_type != self::POST_TYPE )
@@ -803 +803 @@
 
         /**
-         * Attach unattached files to the payment request post
-         *
-         * Sometimes users will upload the files manually to the Media Library, instead of using the Add Files button,
-         * and we need to attach them to the request so that they show up in the metabox.
-         *
-         * @param int   $post_id
-         * @param array $request
-         */
-        protected function attach_existing_files( $post_id, $request ) {
-                if ( empty( $request['wcp_existing_files_to_attach'] ) ) {
-                        return;
-                }
-
-                if ( ! $files = json_decode( $request['wcp_existing_files_to_attach'] ) ) {
-                        return;
-                }
-
-                remove_action( 'save_post', array( $this, 'save_payment' ), 10 ); // avoid infinite recursion
-
-                foreach( $files as $file_id ) {
-                        wp_update_post( array(
-                                'ID'          => $file_id,
-                                'post_parent' => $post_id,
-                        ) );
-                }
-
-                add_action( 'save_post', array( $this, 'save_payment' ), 10, 2 );
-        }
-
-        /**
          * Define columns for the Payment Requests screen.
          *