Changeset 2361

Timestamp:

01/24/2016 06:43:43 PM (9 years ago)

Author:

ocean90

Message:

Translate, Plugin Directory: Reduce number of database queries by fetching all existing sets at once.

See #1352.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/cli/set-plugin-project.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/cli/set-plugin-project.php

@@ -231 +231 @@
         }
 
+        $existing_sets = array();
+        foreach ( GP::$translation_set->by_project_id( $project->id ) as $set ) {
+            $existing_sets[ $set->locale . ':' . $set->slug ] = true;
+        }
+
         foreach ( $translation_sets as $ts ) {
-            if ( empty( $ts ) || empty( $ts->name ) ) {
-                continue;
-            }
-
-            $existing = GP::$translation_set->by_project_id_slug_and_locale( $project->id, $ts->slug, $ts->locale );
-            if ( ! empty( $existing ) ) {
+            if ( isset( $existing_sets[ $ts->locale . ':' . $ts->slug ] ) ) {
+                // This translation set already exists.
                 continue;
             }