Changeset 243

Timestamp:

01/08/2014 11:01:11 PM (11 years ago)

Author:

nacin

Message:

Trac patch: Avoid IndexError that could occur when new tickets are created.

File:

• sites/trunk/trac.wordpress.org/patches/notifications.diff (modified) (3 diffs)

sites/trunk/trac.wordpress.org/patches/notifications.diff

@@ -11 +11 @@
  
  class TicketNotificationSystem(Component):
-@@ -94,6 +95,41 @@
+@@ -94,6 +95,43 @@
                  torecipients.append(row[2])
              break
@@ -26 +26 @@
 +            # Retrieve the old milestone/component if it just changed
 +            changes = ticket.get_changelog()
-+            changes.reverse()
-+            last_change = changes[0]
-+            for change in changes:
-+                if change[0] != last_change[0]:
-+                    break
-+                if change[2] == 'component':
-+                    old_component = change[3]
-+                if change[2] == 'milestone':
-+                    old_milestone = change[3]
++            # New tickets do not have changes
++            if changes:
++                changes.reverse()
++                last_change = changes[0]
++                for change in changes:
++                    if change[0] != last_change[0]:
++                        break
++                    if change[2] == 'component':
++                        old_component = change[3]
++                    if change[2] == 'milestone':
++                        old_milestone = change[3]
 +
 +            # Add component subscribers
@@ -53 +55 @@
          if notify_updater:
              for author, ticket in db("""
-@@ -126,6 +162,12 @@
+@@ -126,6 +164,12 @@
          elif updater:
              torecipients.append(updater)