Changeset 2456 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

Timestamp:

02/03/2016 10:52:41 PM (10 years ago)

Author:

obenland

Message:

W.org Themes: Be more verbose in checking for previous meta values.

The bug fix introduced in [1387] caused every theme to have a version 0.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

@@ -268 +268 @@
  */
 function wporg_themes_update_version_status( $post_id, $current_version, $new_status ) {
-    $meta       = (array) get_post_meta( $post_id, '_status', true );
-    $old_status = isset( $meta[ $current_version ] ) ? $meta[ $current_version ] : false;
+    $meta = get_post_meta( $post_id, '_status', true );
+
+    if ( empty( $meta ) ) {
+        $meta = array();
+        $old_status = false;
+    } else {
+        $old_status = $meta[ $current_version ];
+    }
 
     // Don't do anything when the status hasn't changed.