Changeset 2535

Timestamp:

02/19/2016 12:40:37 AM (9 years ago)

Author:

iandunn

Message:

WordCamp Budgets: Add a few TODO notes.

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins

Files:

• wordcamp-payments-network/includes/reimbursement-requests-dashboard.php (modified) (1 diff)
• wordcamp-payments-network/includes/wordcamp-budgets-dashboard.php (modified) (1 diff)
• wordcamp-payments/includes/sponsor-invoice.php (modified) (1 diff)
• wordcamp-payments/includes/wordcamp-budgets.php (modified) (1 diff)
• wordcamp-payments/views/reimbursement-request/metabox-general-information.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments-network/includes/reimbursement-requests-dashboard.php

@@ -199 +199 @@
     // Drafts, etc aren't displayed in the list table, so there's no reason to index them
     $ignored_statuses = array( 'auto-draft', 'draft', 'trash' );
+    // todo also `inherit`. should switch to whitelist instead of blacklist
 
     if ( in_array( $request->post_status, $ignored_statuses, true ) ) {

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments-network/includes/wordcamp-budgets-dashboard.php

@@ -82 +82 @@
  * Currency Conversion
  *
+ * @todo Now that we're pushing invoices and payments to QuickBooks, we can pull the actual value from their API,
+ * instead of these estimates, which quickly become outdated since the conversion rates change daily.
+ *
  * @param string $from   What currency are we selling.
  * @param string $to     What currency are we buying.

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/sponsor-invoice.php

@@ -347 +347 @@
         $post_data['post_status'] = 'draft';
 
+        // todo display message to user letting them know why this is happening
         // todo this should run after save, b/c sanitization/validation could empty out some fields
 

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/wordcamp-budgets.php

@@ -479 +479 @@
      * Get a list of all world currencies, with the most frequently used at the top.
      *
+     * @todo Bring this in line with ISO 4217
+     *
      * @return array
      */

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/views/reimbursement-request/metabox-general-information.php

@@ -36 +36 @@
                     <option value="<?php echo esc_attr( $currency_key ); ?>" <?php selected( $currency_key, $selected_currency ); ?> >
                         <?php echo esc_html( $currency_name ); ?>
+                        <?php // todo - For better UX, prepend the code to the name (USD - United States Dollar), and sort by the code. Updating the sorting in get_currencies(). Also make this change other places this is used ?>
                     </option>
                 <?php endforeach; ?>