Changeset 2559

Timestamp:

02/23/2016 03:21:23 PM (10 years ago)

Author:

iandunn

Message:

WordCamp QBO: Bump the remote request timeout to 10 seconds.

Some requests in production are timing out. For the most part, our error handling catches that gracefully, but there are some situations that still result in problems.

For instance, if we send a request to create an invoice, the QBO server receives it and proceses it, but doesn't respond in time, then we won't know that it was processed successfully, or the ID of the new invoice. If the deputy then tries to create the invoice again, a duplicate invoice will be created.

We may also need additional checks to prevent duplicates, but this should help mitigate similar problems.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo/wordcamp-qbo.php (modified) (10 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo/wordcamp-qbo.php

@@ -5 +5 @@
 
 class WordCamp_QBO {
+    const REMOTE_REQUEST_TIMEOUT = 10; // seconds
+
     private static $app_token;
     private static $consumer_key;
@@ -166 +168 @@
             $oauth_header = $oauth->get_oauth_header( 'GET', $request_url );
             $response = wp_remote_get( $request_url, array(
+                'timeout' => self::REMOTE_REQUEST_TIMEOUT,
                 'headers' => array(
                     'Authorization' => $oauth_header,
@@ -189 +192 @@
         $oauth_header = $oauth->get_oauth_header( 'POST', $request_url, $payload );
         $response = wp_remote_post( $request_url, array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => $oauth_header,
@@ -248 +252 @@
 
         $oauth_header = $oauth->get_oauth_header( 'GET', $request_url, $args );
-        $response = wp_remote_get( esc_url_raw( add_query_arg( $args, $request_url ) ), array( 'headers' => array(
-            'Authorization' => $oauth_header,
-            'Accept' => 'application/json',
-        ) ) );
+        $response = wp_remote_get(
+            esc_url_raw( add_query_arg( $args, $request_url ) ),
+            array(
+                'timeout' => self::REMOTE_REQUEST_TIMEOUT,
+                'headers' => array(
+                    'Authorization' => $oauth_header,
+                    'Accept' => 'application/json',
+                )
+            )
+        );
 
         if ( is_wp_error( $response ) || wp_remote_retrieve_response_code( $response ) !== 200 ) {
@@ -501 +511 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => $oauth->get_oauth_header( 'POST', $request_url, $payload ),
@@ -563 +574 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => $oauth->get_oauth_header( 'POST', $request_url ),
@@ -687 +699 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => $oauth->get_oauth_header( 'GET', $request_url, $request_url_query ),
@@ -824 +837 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => $oauth->get_oauth_header( 'POST', $request_url, $payload ),
@@ -921 +935 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => $oauth->get_oauth_header( 'GET', $request_url, $request_url_query ),
@@ -1031 +1046 @@
 
             $oauth_header = $oauth->get_oauth_header( 'GET', $request_url );
-            $response = wp_remote_get( $request_url, array( 'headers' => array(
-                'Authorization' => $oauth_header,
-                'Accept' => 'application/json',
-            ) ) );
+            $response = wp_remote_get( $request_url, array(
+                'timeout' => self::REMOTE_REQUEST_TIMEOUT,
+                'headers' => array(
+                    'Authorization' => $oauth_header,
+                    'Accept' => 'application/json',
+                )
+            ) );
 
             if ( is_wp_error( $response ) ) {